fix(social): correct search_social_posts response parsing - #21
Open
appressman wants to merge 3 commits into
Open
fix(social): correct search_social_posts response parsing#21appressman wants to merge 3 commits into
appressman wants to merge 3 commits into
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The /posts/list API returns results nested under a `results` key
({ results: { posts, total } }) but the tool was reading response.data.posts
directly, always resolving to undefined and returning an empty list.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesSocial Search Response Normalization
Repository Configuration
Estimated code review effort: 1 (Trivial) | ~5 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This repo's remote is appressman/GoHighLevel-MCP, a public fork, and CREDENTIALS.md sat untracked but unignored. A `git add -A` here would have published it. Verified against full history on all branches that it was never committed, so this is a guard, not a cleanup, and no rotation is needed. Also covers the obvious neighbours: *.pem, *.key, secrets*, and *credentials*.json. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Fg1zzArGn8eJFKEWoXg3Bc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
search_social_postsalways returns an empty list (count: 0, posts: []) regardless of what's in the Social Planner.Root Cause
The
POST /social-media-posting/{locationId}/posts/listendpoint wraps its response under aresultskey:{ "results": { "posts": [...], "total": 99 } }The tool was reading
response.data?.postsdirectly, which is alwaysundefined— so every search silently returns nothing.Fix
src/tools/social-media-tools.ts— readsresponse.data?.results?.postswith fallback toresponse.data?.postsfor backwards compatibilitysrc/types/ghl-types.ts— addedresults?: { posts, total }toGHLSearchPostsResponseto match the actual API shapeTested against a live GHL location — confirmed 99 published posts returned correctly after the fix.
🤖 Generated with Claude Code
Summary by CodeRabbit
Release Notes
Improvements
Security
Chores