Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { Provider } from "jotai";
import React from "react";
import { beforeEach, describe, expect, it, vi } from "vitest";
import { MockRequestClient } from "@/__mocks__/requests";
import { viewStateAtom } from "@/core/mode";
import { requestClientAtom } from "@/core/network/requests";
import { store } from "@/core/state/jotai";
import { InstallPackageButton } from "../install-package-button";
Expand Down Expand Up @@ -48,6 +49,7 @@ describe("InstallPackageButton", () => {
beforeEach(() => {
vi.clearAllMocks();
store.set(requestClientAtom, MockRequestClient.create());
store.set(viewStateAtom, { mode: "edit", cellAnchor: null });
});

it("should not render when packages is undefined", () => {
Expand Down Expand Up @@ -82,4 +84,13 @@ describe("InstallPackageButton", () => {
);
expect(screen.getByText("Install altair")).toBeInTheDocument();
});

it("should not render in read mode, where installs are not allowed", () => {
store.set(viewStateAtom, { mode: "read", cellAnchor: null });
const { container } = render(
<InstallPackageButton packages={["altair"]} />,
{ wrapper },
);
expect(container.firstChild).toBeNull();
});
});
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import React from "react";
import { Button } from "@/components/ui/button";
import { useInstallAllowed } from "@/core/mode";
import { useInstallPackages } from "@/core/packages/useInstallPackage";
import { cn } from "@/utils/cn";

Expand All @@ -23,8 +24,9 @@ export const InstallPackageButton: React.FC<InstallPackageButtonProps> = ({
onInstall,
}) => {
const { handleInstallPackages } = useInstallPackages();
const installAllowed = useInstallAllowed();

if (!packages || packages.length === 0) {
if (!packages || packages.length === 0 || !installAllowed) {
return null;
}

Expand Down
Loading