chore: require descriptive snapshot hints - #10892
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
Coverage Report for ./frontend
File CoverageNo changed files found. |
Light2Dark
marked this pull request as ready for review
September 18, 2026 03:17
Light2Dark
requested review from
kirangadhave
and
a lite review from Copilot
September 18, 2026 03:17
Light2Dark
enabled auto-merge (squash)
September 18, 2026 03:17
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Remaining unhinted snapshots will cause the frontend lint check to fail.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This pull request adds descriptive Vitest snapshot hints and updates snapshot keys without changing stored values.
Changes:
- Adds lifecycle-specific hints to cell snapshots.
- Adds descriptive hints to database snapshots.
- Removes the Oxlint suppression for snapshot hints.
- Renames corresponding snapshot keys.
Critical issue (2 votes): 91 unhinted snapshot calls remain elsewhere, causing the frontend lint check to fail.
File summaries
| File | Description |
|---|---|
frontend/src/core/cells/__tests__/cells.test.ts |
Adds cell-state snapshot hints. |
frontend/src/core/cells/__tests__/__snapshots__/cells.test.ts.snap |
Renames cell snapshot keys. |
frontend/src/components/editor/connections/database/__tests__/as-code.test.ts |
Adds database snapshot hints. |
frontend/src/components/editor/connections/database/__tests__/__snapshots__/as-code.test.ts.snap |
Renames database snapshot keys. |
frontend/.oxlintrc.json |
Removes the snapshot-hint suppression. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -72,8 +72,6 @@ | |||
| "error", | |||
| { "additionalTestBlockFunctions": ["beforeEach"] } | |||
| ], | |||
kirangadhave
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was authored by a coding agent.
📝 Summary
Vitest snapshot files used numeric suffixes when a test contained several snapshots, which made failures difficult to map back to a lifecycle step. This enables
vitest/prefer-snapshot-hintand gives the existing database-code and cell-state snapshots stable, descriptive names.The stored snapshot values are unchanged; only their keys are renamed.
📋 Pre-Review Checklist
✅ Merge Checklist