fix: preserve numeric and text types in CSV charts - #10869
Open
Light2Dark wants to merge 4 commits into
Open
Light2Dark wants to merge 4 commits into
Light2Dark wants to merge 4 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Coverage Report for ./frontend
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||||||||
Contributor
There was a problem hiding this comment.
Review completed against the latest diff
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Schema-less lazy tables incorrectly use sample-derived explicit parsing instead of full-CSV automatic inference.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds schema-aware CSV parsing for chart data while preserving text values and supporting infinities.
Changes:
- Adds numeric infinity and opt-in date parsing.
- Passes table column types into chart CSV loading.
- Expands loader and ChartPanel tests.
File summaries
| File | Description |
|---|---|
frontend/src/plugins/impl/vega/utils.ts |
Adds configurable date parsing. |
frontend/src/plugins/impl/vega/loader.ts |
Parses numeric infinity values. |
frontend/src/plugins/impl/vega/__tests__/vega.test.ts |
Tests typed CSV parsing. |
frontend/src/plugins/impl/vega/__tests__/utils.test.ts |
Tests date parsing options. |
frontend/src/components/data-table/charts/charts.tsx |
Applies field metadata to CSV charts. |
frontend/src/components/data-table/charts/__tests__/chart-panel.test.tsx |
Tests chart loading and schema changes. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Light2Dark
marked this pull request as ready for review
September 17, 2026 03:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was authored by a coding agent.
📝 Summary
codex/fix-dotted-chart-columns.inf,+inf, and-infremain distinct from missing values, while text such asinfand001keeps its original representation.Screenshot
user.namelabels rendering correctly. This image illustrates the parent fix.📋 Pre-Review Checklist
✅ Merge Checklist