Conversation
The Polars serialization fix preserves the cache format. Keep version 5 for new writes and verify that entries marked version 5 or 6 remain readable.
|
Deployment failed for project marimo-docs with the following error: View Documentation: https://vercel.com/docs/accounts/team-members-and-roles |
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
dmadisetti
reviewed
Sep 15, 2026
Comment on lines
+79
to
+81
| if type(value).__module__.startswith("polars."): | ||
| dtypes = value.dtypes if hasattr(value, "dtypes") else [value.dtype] | ||
| return all(dtype.is_numeric() for dtype in dtypes) |
Member
There was a problem hiding this comment.
Isn't this the same as below? I think we can consolidate this logic while we're here
dmadisetti
reviewed
Sep 15, 2026
|
|
||
| # NB. Increment on cache breaking changes. | ||
| MARIMO_CACHE_VERSION: int = 6 | ||
| MARIMO_CACHE_VERSION: int = 5 |
Member
There was a problem hiding this comment.
It's fine, I am going to cache invalidate soon. Will put you on that PR
Collaborator
Author
There was a problem hiding this comment.
okay, so will revert to = 6
Route Polars Series and DataFrames through the existing Narwhals schema check while preserving NumPy and pandas Series classification.
Bundle ReportChanges will increase total bundle size by 55.45kB (0.21%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: marimo-esmAssets Changed:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brief follow-up on #10775