Skip to content

fix: Bug: intermittent empty highlights with allow_empty=true on distributed ... - #4845

Open
Roshan931 wants to merge 1 commit into
manticoresoftware:mainfrom
Roshan931:prilog/fix-error-merged-distributed-result-set-evaluates-08-21-2026-52301c
Open

fix: Bug: intermittent empty highlights with allow_empty=true on distributed ...#4845
Roshan931 wants to merge 1 commit into
manticoresoftware:mainfrom
Roshan931:prilog/fix-error-merged-distributed-result-set-evaluates-08-21-2026-52301c

Conversation

@Roshan931

Copy link
Copy Markdown

Fixes #4769

Root cause

Merged distributed result set evaluates HIGHLIGHT/SNIPPET with one table's expression

Changes

  • In minimize_aggr_result.cpp the post-limit expressions of every local result set are now collected per tag right after tags are compacted (while the per-table schemas are still in place) and ProcessMultiPostlimit evaluates each merged match with the expression belonging to the table the match came from, falling back to the merged-schema expression when no per-tag one exists. Added a CLT regression test with a distributed table over two locals with different morphology.

@sanikolaev
sanikolaev requested a review from klirichek August 24, 2026 10:21

@klirichek klirichek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in description of the PR you've promised a test.
In that very case even ubertest is perfect solution, since the bug should be easy reproduced on a few modeling data (i.e. no need to setup/construct MCL test with startup logic, non-trivial console tricks, etc).

Actually only one file changed; no test provided.
The change is not trivial typo correction somewhere in the comments, so, it NEED to be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: intermittent empty highlights with allow_empty=true on distributed index containing local indexes with different morphology

3 participants