fix: preserve docid for UUID stored-field retrieval - #4841
Merged
Conversation
klirichek
reviewed
Aug 21, 2026
klirichek
requested changes
Aug 21, 2026
klirichek
left a comment
klirichek
left a comment
Contributor
There was a problem hiding this comment.
just remove unneccessary comment from code. It clearify actually nothing, and looks much more clear without extra words.
klirichek
approved these changes
Aug 24, 2026
Collaborator
Author
|
I'll fix the tests. It turns out they failed after the initial commit in the branch. |
Keep the numeric docid in the sorter schema only when a SphinxQL query selects a stored field or `*`, so docstore lookup remains available. Keep the regular public UUID `id` projection for all other SQL, HTTP, and JSON queries. Isolate the affected UUID ubertests in their own data directory to avoid stale persisted RT data across repeated runs. Related issue: #4833
klirichek
reviewed
Aug 24, 2026
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: http://github.com/manticoresoftware/manticoresearch/issues/4833