fix: normalize German sharp s in German morphology - #4836
Open
sanikolaev wants to merge 1 commit into
Open
Conversation
Add the `german` charset alias so tables can preserve German umlauts and sharp s with `charset_table=non_cont,german`. Treat ß, capital ẞ, and ss as search equivalents for German AOT lemmatization while retaining exact-word distinctions. Version the German morphology fingerprint, warn when existing plain or RT tables need rebuilding, and add plain/RT regression coverage for both German lemmatization modes. Related issue: #4827
sanikolaev
force-pushed
the
fix/4827-german-sharp-s
branch
from
August 21, 2026 06:04
b3e436b to
ff72220
Compare
5 tasks
Collaborator
Author
|
Previously discussed in the issue:
@tomatolog: "we can not just change the defaults as users using the defaults \ existed charset table would get the different settings \ data indexed for new tables \ RT table disk chunks and would complain that after upgrade old tables \ RT disk chunks would produce warnings or will not return the same results as the new tables \ disk chunks" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #4827
The issue had two parts:
non_contconverted ß to a single s before morphology, and German AOT did not treat ß/ẞ and ss as equivalent.The fix:
charset_table = non_cont, germanto preserve German characters;lemmatize_deandlemmatize_de_all;