Remove legacy Warden runtime and preserve protocol boundary - #84
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The old Warden implementation is being removed from One–Four before the reviewed Zero redesign is ported. This leaves a small, explicit protocol boundary instead of carrying an untrusted and largely dormant anti-cheat implementation.
Security and compatibility
Leave Four's existing authentication/session admission path unchanged while removing dead Warden coupling. No redesigned checks, Classic module data, or enforcement policy are introduced by this PR.
The required database markers are Realm 22.04.001, Character 23.03.001, and World 23.04.001.
Dependencies
Merge after mangos/realmd#40 and mangosfour/Database#5.
Validation
The bounded Release build passed; focused non-interactive tests passed 11/11; opcode overlay generation is idempotent and its shared-alias totals reconcile. The aggregate local CTest is not claimed because one harness test needed the staged OpenSSL legacy provider and another opened a Windows popup. Parent/submodule worktrees are clean and
git diff --checkpasses.