feat: add SearchPath rule coverage - #1175
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed |
mike-hunhoff
left a comment
There was a problem hiding this comment.
Thank you @w3lld1 , I've left a few comments for your review. We can merge when those are addressed, assuming CI passes.
|
Thanks — addressed all three review comments in
Fresh validation:
|
mike-hunhoff
left a comment
There was a problem hiding this comment.
One last quick change before merge, assuming CI passes.
|
Addressed the final suggestion in |
|
@w3lld1 CI if failing: Please address and ensure lints are passing locally before requesting another review. |
|
Thanks — renamed the rule file to |
Summary
I added a nursery rule that identifies calls to the Windows
SearchPathAPI. The base API feature covers bothSearchPathAandSearchPathWwhile keeping the rule concise.Validation
python scripts/capafmt.py --check rules/nursery/search-for-file-via-searchpath.ymlpython scripts/lint.py --thorough -t "search for file via SearchPath" -v rules/SearchPathAandSearchPathWtokernel32.SearchPathgit diff --checkThe full corpus CI suite was not run locally because it requires the separate capa-testfiles corpus; I left that validation to CI.
Fixes #1174