Add iOS artifact clipboard paste flows

Packages/Shared/CMUXMobileCore/Sources/CMUXMobileCore/DiagnosticBuildStamp.swift

@@ -5,9 +5,11 @@ import Foundation
 /// The git SHA and dev tag are signed bundle metadata, not runtime input. The
 /// helper keeps iOS and macOS reports comparable and applies the same bounded
 /// sanitization at their shared boundary.
-public enum DiagnosticBuildStamp {
+public struct DiagnosticBuildStamp {
+    public init() {}
+
     /// Returns a bounded `name version (build) tag sha` stamp from bundle data.
-    public static func make(
+    public func make(
         infoDictionary: [String: Any]?,
         fallbackName: String = "cmux"
     ) -> String {
@@ -30,7 +32,7 @@ public enum DiagnosticBuildStamp {
         return DiagnosticReport.sanitizeBuildStamp(result)
     }
 
-    private static func nonEmptyString(_ value: Any?) -> String? {
+    private func nonEmptyString(_ value: Any?) -> String? {
         guard let value = value as? String else { return nil }
         let trimmed = value.trimmingCharacters(in: .whitespacesAndNewlines)
         return trimmed.isEmpty ? nil : trimmed

Packages/Shared/CMUXMobileCore/Tests/CMUXMobileCoreTests/DiagnosticBuildStampTests.swift

@@ -3,7 +3,7 @@ import Testing
 
 @Suite struct DiagnosticBuildStampTests {
     @Test func includesSignedTagAndShaWithoutRuntimeInput() {
-        let stamp = DiagnosticBuildStamp.make(infoDictionary: [
+        let stamp = DiagnosticBuildStamp().make(infoDictionary: [
             "CFBundleName": "cmux",
             "CFBundleShortVersionString": "1.2.3",
             "CFBundleVersion": "42",
@@ -15,7 +15,7 @@ import Testing
     }
 
     @Test func removesUnsafeBundleMetadata() {
-        let stamp = DiagnosticBuildStamp.make(infoDictionary: [
+        let stamp = DiagnosticBuildStamp().make(infoDictionary: [
             "CFBundleName": "cmux/unsafe",
             "CFBundleShortVersionString": "1\n2",
             "CFBundleVersion": "7",

Packages/iOS/CmuxAgentChatUI/Sources/CmuxAgentChatUI/Artifacts/ChatArtifactAction.swift

@@ -8,6 +8,8 @@ public enum ChatArtifactAction: Hashable, Sendable {
     case save
     /// Copies loaded image data to the system pasteboard.
     case copyImage
+    /// Copies a materialized artifact file to the system pasteboard.
+    case copyFile
     /// Copies the artifact's rendered text contents.
     case copyContents
     /// Copies the artifact's remote path.
@@ -22,6 +24,8 @@ public enum ChatArtifactAction: Hashable, Sendable {
             String(localized: "chat.artifact.save_to_files", defaultValue: "Save to Files", bundle: .module)
         case .copyImage:
             String(localized: "chat.artifact.copy_image", defaultValue: "Copy image", bundle: .module)
+        case .copyFile:
+            String(localized: "chat.artifact.copy_file", defaultValue: "Copy file", bundle: .module)
         case .copyContents:
             String(localized: "chat.artifact.copy_contents", defaultValue: "Copy contents", bundle: .module)
         case .copyPath:
@@ -36,7 +40,7 @@ public enum ChatArtifactAction: Hashable, Sendable {
             "square.and.arrow.up"
         case .save:
             "folder.badge.plus"
-        case .copyImage:
+        case .copyImage, .copyFile:
             "doc.on.doc"
         case .copyContents:
             "doc.on.doc"

Packages/iOS/CmuxAgentChatUI/Sources/CmuxAgentChatUI/Artifacts/ChatArtifactActionVisibilityPolicy.swift

@@ -12,13 +12,13 @@ struct ChatArtifactActionVisibilityPolicy: Equatable {
             actions = Self.imageActions
             inlineStateIdentity = "image"
         case .pdf:
-            actions = [.share, .save]
+            actions = [.share, .save, .copyFile]
             inlineStateIdentity = "pdf"
         case .media:
-            actions = [.share, .save]
+            actions = [.share, .save, .copyFile]
             inlineStateIdentity = "media"
         case .quickLook:
-            actions = [.share, .save]
+            actions = [.share, .save, .copyFile]
             inlineStateIdentity = "quick-look"
         case .loading, .folder, .text, .markdown, .binary, .failure:
             actions = []
@@ -38,7 +38,7 @@ struct ChatArtifactActionVisibilityPolicy: Equatable {
             return
         }
         actions = isTextFile
-            ? [.share, .save, .copyContents, .copyPath]
-            : [.share, .save, .copyPath]
+            ? [.share, .save, .copyFile, .copyContents, .copyPath]
+            : [.share, .save, .copyFile, .copyPath]
     }
 }

Packages/iOS/CmuxAgentChatUI/Sources/CmuxAgentChatUI/Artifacts/ChatArtifactInlineViewer.swift

@@ -132,6 +132,8 @@ public struct ChatArtifactInlineViewer: View {
             guard case .image(let data) = pageModel.snapshot.state else { return }
             UIPasteboard.general.image = UIImage(data: data)
             loader.recordDiagnostic(.artifactCopied)
+        case .copyFile:
+            Task { _ = await pageModel.copyFile(loader: loader) }
         case .copyContents, .copyPath:
             break
         }

Packages/iOS/CmuxAgentChatUI/Sources/CmuxAgentChatUI/Artifacts/ChatArtifactViewerPageModel.swift

@@ -3,6 +3,10 @@ import CmuxAgentChat
 import Foundation
 import Observation
 
+#if os(iOS)
+import UIKit
+#endif
+
 /// Owns mutable content and controls for one stable artifact path.
 @Observable
 @MainActor
@@ -230,6 +234,28 @@ final class ChatArtifactViewerPageModel {
         )
     }
 
+    func copyFile(loader: ChatArtifactLoader) async -> Bool {
+        guard !fileActionState.isRunning else { return false }
+        fileActionState.failure = nil
+        fileActionState.isRunning = true
+        defer { fileActionState.isRunning = false }
+        do {
+            let fileURL = try await ChatArtifactFileActionStore.applicationDefault.materialize(
+                path: path,
+                loader: loader
+            )
+            try Task.checkCancellation()
+            UIPasteboard.general.urls = [fileURL]
+            loader.recordDiagnostic(.artifactCopied)
+            return true
+        } catch is CancellationError {
+            return false
+        } catch {
+            fileActionState.failure = (error as? ChatArtifactError) ?? .loadFailed
+            return false
+        }
+    }
+
     func setFileActionPresentation(_ presentation: ChatArtifactFileActionPresentation?) {
         fileActionState.presentation = presentation
     }

Packages/iOS/CmuxAgentChatUI/Sources/CmuxAgentChatUI/Artifacts/ChatArtifactViewerPager.swift

@@ -221,6 +221,11 @@ struct ChatArtifactViewerPager: View {
             UIPasteboard.general.image = UIImage(data: data)
             loader.recordDiagnostic(.artifactCopied)
             toasts.present(.copied())
+        case .copyFile:
+            Task {
+                guard await model.copyFile(for: snapshot.path, loader: loader) else { return }
+                toasts.present(.copied())
+            }
         case .copyContents:
             UIPasteboard.general.string = snapshot.renderedText
             loader.recordDiagnostic(.artifactCopied)

Packages/iOS/CmuxAgentChatUI/Sources/CmuxAgentChatUI/Artifacts/ChatArtifactViewerPagerModel.swift

@@ -122,6 +122,11 @@ final class ChatArtifactViewerPagerModel {
         await page.prepareSave(loader: loader)
     }
 
+    func copyFile(for path: String, loader: ChatArtifactLoader) async -> Bool {
+        guard let page = pageModel(for: path) else { return false }
+        return await page.copyFile(loader: loader)
+    }
+
     func setFileActionPresentation(
         _ presentation: ChatArtifactFileActionPresentation?,
         for path: String

Packages/iOS/CmuxAgentChatUI/Sources/CmuxAgentChatUI/Composer/ChatComposerView.swift

@@ -394,9 +394,30 @@ public struct ChatComposerView: View {
     }
 
     private var attachButton: some View {
-        Button {
-            onDiagnosticEvent(.photoPickerOpened)
-            isPhotoPickerPresented = true
+        Menu {
+            Button {
+                onDiagnosticEvent(.photoPickerOpened)
+                isPhotoPickerPresented = true
+            } label: {
+                Label(
+                    String(
+                        localized: "chat.composer.attach.photo",
+                        defaultValue: "Photo Library",
+                        bundle: .module
+                    ),
+                    systemImage: "photo.on.rectangle"
+                )
+            }
+            Button(action: performPaste) {
+                Label(
+                    String(
+                        localized: "chat.composer.attach.paste",
+                        defaultValue: "Paste Attachment",
+                        bundle: .module
+                    ),
+                    systemImage: "doc.on.clipboard"
+                )
+            }
         } label: {
             MobileComposerIconLabel(
                 systemImage: "paperclip",

Packages/iOS/CmuxAgentChatUI/Sources/CmuxAgentChatUI/Resources/Localizable.xcstrings

@@ -460,6 +460,23 @@
         }
       }
     },
+    "chat.artifact.copy_file": {
+      "extractionState": "manual",
+      "localizations": {
+        "en": {
+          "stringUnit": {
+            "state": "translated",
+            "value": "Copy file"
+          }
+        },
+        "ja": {
+          "stringUnit": {
+            "state": "translated",
+            "value": "ファイルをコピー"
+          }
+        }
+      }
+    },
     "chat.artifact.copy_image": {
       "extractionState": "manual",
       "localizations": {
@@ -3010,6 +3027,20 @@
         }
       }
     },
+    "chat.composer.attach.photo": {
+      "extractionState": "manual",
+      "localizations": {
+        "en": { "stringUnit": { "state": "translated", "value": "Photo Library" } },
+        "ja": { "stringUnit": { "state": "translated", "value": "写真ライブラリ" } }
+      }
+    },
+    "chat.composer.attach.paste": {
+      "extractionState": "manual",
+      "localizations": {
+        "en": { "stringUnit": { "state": "translated", "value": "Paste Attachment" } },
+        "ja": { "stringUnit": { "state": "translated", "value": "添付ファイルをペースト" } }
+      }
+    },
     "chat.unsupported": {
       "extractionState": "manual",
       "localizations": {

Packages/iOS/CmuxAgentChatUI/Tests/CmuxAgentChatUITests/ChatArtifactActionVisibilityPolicyTests.swift

@@ -16,6 +16,7 @@ struct ChatArtifactActionVisibilityPolicyTests {
         #expect(ChatArtifactAction.share.systemImage == "square.and.arrow.up")
         #expect(ChatArtifactAction.save.systemImage == "folder.badge.plus")
         #expect(ChatArtifactAction.copyImage.systemImage == "doc.on.doc")
+        #expect(ChatArtifactAction.copyFile.systemImage == "doc.on.doc")
         #expect(ChatArtifactAction.copyContents.systemImage == "doc.on.doc")
         #expect(ChatArtifactAction.copyPath.systemImage == "link")
     }
@@ -24,9 +25,9 @@ struct ChatArtifactActionVisibilityPolicyTests {
     func documentPreviewsOfferShareAndSave() {
         let url = URL(fileURLWithPath: "/tmp/artifact")
 
-        #expect(ChatArtifactActionVisibilityPolicy(inlineState: .pdf(fileURL: url)).actions == [.share, .save])
-        #expect(ChatArtifactActionVisibilityPolicy(inlineState: .media(fileURL: url)).actions == [.share, .save])
-        #expect(ChatArtifactActionVisibilityPolicy(inlineState: .quickLook(fileURL: url)).actions == [.share, .save])
+        #expect(ChatArtifactActionVisibilityPolicy(inlineState: .pdf(fileURL: url)).actions == [.share, .save, .copyFile])
+        #expect(ChatArtifactActionVisibilityPolicy(inlineState: .media(fileURL: url)).actions == [.share, .save, .copyFile])
+        #expect(ChatArtifactActionVisibilityPolicy(inlineState: .quickLook(fileURL: url)).actions == [.share, .save, .copyFile])
     }
 
     @Test
@@ -61,11 +62,11 @@ struct ChatArtifactActionVisibilityPolicyTests {
         #expect(ChatArtifactActionVisibilityPolicy(
             viewerHasFileActions: true,
             isTextFile: false
-        ).actions == [.share, .save, .copyPath])
+        ).actions == [.share, .save, .copyFile, .copyPath])
         #expect(ChatArtifactActionVisibilityPolicy(
             viewerHasFileActions: true,
             isTextFile: true
-        ).actions == [.share, .save, .copyContents, .copyPath])
+        ).actions == [.share, .save, .copyFile, .copyContents, .copyPath])
         #expect(ChatArtifactActionVisibilityPolicy(
             viewerHasFileActions: false,
             isTextFile: false

Packages/iOS/CmuxMobileShell/Sources/CmuxMobileShell/MobileShellComposite+TaskAttachments.swift

@@ -4,6 +4,25 @@ public import CmuxMobileShellModel
 public import Foundation
 
 extension MobileShellComposite {
+    /// Uploads a file selected for the active terminal composer and returns the
+    /// Mac-local path that can be inserted into the draft.
+    ///
+    /// - Parameter attachment: App-owned staged attachment file to upload.
+    /// - Returns: The final absolute Mac path, or a user-actionable failure.
+    public func uploadTerminalComposerAttachment(
+        _ attachment: TaskComposerAttachment
+    ) async -> Result<String, MobileWorkspaceMutationFailure> {
+        guard let macDeviceID = foregroundMacDeviceID else {
+            return .failure(.notConnected(hostDisplayName: nil))
+        }
+        return await uploadTaskAttachment(
+            attachment,
+            operationID: UUID(),
+            macDeviceID: macDeviceID,
+            instanceTag: activeMacInstanceTag
+        )
+    }
+
     /// Whether the selected Mac instance currently advertises task attachments.
     ///
     /// - Parameters:

Packages/iOS/CmuxMobileShellUI/Sources/CmuxMobileShellUI/Resources/Localizable.xcstrings

@@ -1608,6 +1608,41 @@
       "en" : { "stringUnit" : { "state" : "translated", "value" : "Update cmux on both devices. If needed, remove and pair the Mac again." } },
       "ja" : { "stringUnit" : { "state" : "translated", "value" : "両方のデバイスで cmux を更新してください。必要に応じて Mac を削除し、再度ペアリングしてください。" } }
     } },
+    "mobile.taskComposer.attachments.paste" : {
+      "extractionState" : "manual",
+      "localizations" : {
+        "en" : { "stringUnit" : { "state" : "translated", "value" : "Paste Attachment" } },
+        "ja" : { "stringUnit" : { "state" : "translated", "value" : "添付ファイルをペースト" } }
+      }
+    },
+    "mobile.composer.attach" : { "extractionState" : "manual", "localizations" : {
+      "en" : { "stringUnit" : { "state" : "translated", "value" : "Add Attachment" } },
+      "ja" : { "stringUnit" : { "state" : "translated", "value" : "添付ファイルを追加" } }
+    } },
+    "mobile.composer.attach.photo" : { "extractionState" : "manual", "localizations" : {
+      "en" : { "stringUnit" : { "state" : "translated", "value" : "Photo Library" } },
+      "ja" : { "stringUnit" : { "state" : "translated", "value" : "写真ライブラリ" } }
+    } },
+    "mobile.composer.attach.file" : { "extractionState" : "manual", "localizations" : {
+      "en" : { "stringUnit" : { "state" : "translated", "value" : "Choose Files" } },
+      "ja" : { "stringUnit" : { "state" : "translated", "value" : "ファイルを選択" } }
+    } },
+    "mobile.composer.attach.paste" : { "extractionState" : "manual", "localizations" : {
+      "en" : { "stringUnit" : { "state" : "translated", "value" : "Paste Attachment" } },
+      "ja" : { "stringUnit" : { "state" : "translated", "value" : "添付ファイルをペースト" } }
+    } },
+    "mobile.composer.attach.error" : { "extractionState" : "manual", "localizations" : {
+      "en" : { "stringUnit" : { "state" : "translated", "value" : "Couldn’t Add Attachment" } },
+      "ja" : { "stringUnit" : { "state" : "translated", "value" : "添付ファイルを追加できませんでした" } }
+    } },
+    "mobile.composer.attach.unreadable" : { "extractionState" : "manual", "localizations" : {
+      "en" : { "stringUnit" : { "state" : "translated", "value" : "That file couldn’t be read. Choose another file." } },
+      "ja" : { "stringUnit" : { "state" : "translated", "value" : "そのファイルを読み込めませんでした。別のファイルを選択してください。" } }
+    } },
+    "mobile.composer.attach.uploadFailed" : { "extractionState" : "manual", "localizations" : {
+      "en" : { "stringUnit" : { "state" : "translated", "value" : "The file couldn’t be uploaded to your Mac." } },
+      "ja" : { "stringUnit" : { "state" : "translated", "value" : "ファイルを Mac にアップロードできませんでした。" } }
+    } },
     "mobile.iroh.diagnostics.failure.unknown" : {
       "extractionState" : "manual",
       "localizations" : {

Packages/iOS/CmuxMobileShellUI/Sources/CmuxMobileShellUI/TaskComposer/TaskComposerAttachmentPickerMenu.swift

@@ -13,6 +13,7 @@ struct TaskComposerAttachmentPickerMenu: View {
     let isDisabled: Bool
     let choosePhotos: () -> Void
     let chooseFiles: () -> Void
+    let paste: () -> Void
 
     var body: some View {
         Menu {
@@ -34,6 +35,15 @@ struct TaskComposerAttachmentPickerMenu: View {
                     systemImage: "folder"
                 )
             }
+            Button(action: paste) {
+                Label(
+                    L10n.string(
+                        "mobile.taskComposer.attachments.paste",
+                        defaultValue: "Paste Attachment"
+                    ),
+                    systemImage: "doc.on.clipboard"
+                )
+            }
         } label: {
             switch style {
             case .circularPlus: