ci: hydrate Rust in trusted Testbox broker - #10141
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 16e715be98
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| - name: Install repository-pinned Zig | ||
| shell: bash | ||
| run: ./scripts/install-zig-ci.sh |
There was a problem hiding this comment.
Keep post-token setup inside the broker helper boundary
After Begin Testbox, the required workflow-guard-tests job runs tests/test_testbox_workflow_security.py, which rejects repository scripts outside scripts/blacksmith-testbox-broker/ and local ./.github actions. This invocation therefore fails with post-token script is outside the trusted broker directory: scripts/install-zig-ci.sh; after fixing it, the following setup-cmux-tui-rust local action would fail the same guard. Route both setup operations through the trusted broker boundary or deliberately update the guard and its trust policy.
Useful? React with 👍 / 👎.
999b8cd to
75a2bb9
Compare
|
Superseded by the product-native Testbox workflow in #10135. The replacement uses the pinned Blacksmith lifecycle actions and no custom hydration broker. |
This PR is stacked on #10135. Keep the trust-boundary PR separate. PR 10135 alone does not enable Rust builds.
Summary
The candidate checkout is input data. The workflow does not source a candidate shell script. The warm build can execute the reviewed Rust source only after the token isolation work in the base PR is complete.
Static verification
All checks passed at 16e715b. No local Cargo, Rust, Zig, Xcode, or Testbox command ran.
Timing plan
After both PRs merge and the protected environment pins the exact broker and reviewed source identities:
Expected result
Testbox reuse should beat repeated clean builds near the third build. It is unlikely to beat the M5 Max end-to-end warm loop because each remote build adds sync and control delay. The Testbox value is a safe, repeatable Linux lane, not a proven faster local edit loop.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Hydrates Rust in the trusted Testbox broker so CI can safely prepare and run Rust builds. Previously the broker integration validated the trust boundary but could not enable Rust builds; now CI prepares the reviewed source, pins toolchains, fetches dependencies, installs a warm-build entrypoint, and records a verifiable setup identity.
scripts/blacksmith-testbox-broker/setup.shwith prepare/hydrate/warm-build:clang,libclang-dev,pkg-config), fetches Zig and Cargo dependencies without compilation./tmp/.testbox/cmux-tui-rust-warm-build.flockand a 20-minutetimeout..github/workflows/ci-workflow-guard-tests-testbox-broker.yml:scripts/install-zig-ci.sh, and sets up Rust via./.github/actions/setup-cmux-tui-rust.actions/upload-artifact.Review and rollout
BLACKSMITH_TESTBOX_BROKER_SHA,BLACKSMITH_TESTBOX_REVIEWED_REF,BLACKSMITH_TESTBOX_REVIEWED_SHA, andinputs.testbox_idare set in the protected environment.cmux-tui/rust-toolchain.tomlmatches the repository action pin.Written for commit 16e715b. Summary will update on new commits.