fix: verify Codex resume binding ownership - #10100
Draft
austinywang wants to merge 2 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
To use Codex here, create a Codex account and connect to github. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
state_5.sqlitethread and rolloutsession_metaidentity before publishing a surface resume binding.Fixes #9629.
Fixes #10047.
Testing
CMUXAgentLaunchpackage suite: 308 tests in 44 suites passed../scripts/lint-pbxproj-test-wiring.shpassed (688 files checked)../scripts/check-pbxproj.shpassed after normalization.Package.resolvedpolicy checks passed.CLI/cmux.swiftand the new CLI extension.Demo Video
Review Trigger (Copy/Paste as PR comment)
Checklist
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Enforces verified Codex ownership of surface resume bindings and applies a no-downgrade policy. Previously Codex hooks could replace or clear a binding on ad-hoc evidence; now the CLI verifies against
state_5.sqliteand rollout files, classifies provenance, and preserves the last-known-good binding when Codex state is unreadable.AgentResumeEvidenceProvenance,CodexSessionResumeVerification, andCodexSessionResumeVerifierinCMUXAgentLaunch; verification readsthreadsinstate_5.sqlite, validates rollout JSONL, and classifies TUI, unknown, exec, and subagent provenance.CLI/cmux.swiftthrough a canReplace check: queriessurface.resume.get, prevents lower-provenance rebinding (exec/subagent never own), and logs privacy-safe rejection breadcrumbs. For Codex, resume-command unavailability no longer clears an existing binding.Rollout
surface.resume.getis unsupported on the app, Codex publishing proceeds with legacy behavior.Written for commit 4f10c3b. Summary will update on new commits.