Fix iOS live terminal blank and flashing frames - #10097
Open
azooz2003-bit wants to merge 12 commits into
Open
Conversation
|
Caution Review failedAn error occurred during the review process. Please try again later. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
lvsyncsucceededFixes the takeover regression where scrolling during live agent output could reveal a blank cursor-only surface or flash/reorder rows.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.Summary by cubic
Serialize live terminal frame presentation and harden keyboard dock transitions to eliminate blank/flash frames during live output and preserve animation ordering on iOS.
TerminalRenderPresentationGateinCmuxMobileTerminalto serialize ordinary, local-scroll, and verified-replay frames. Keep the snapshot fallback visible until the matching tokened frame is presented; cancel failed verified-replay submissions; coalesce renders behind the platform presentation callback.GhosttySurfaceRepresentable.beginFrameandbeginOverlapinCmuxMobileSupport’sMobileKeyboardTransition; introduce aKeyboardNotificationTransitionLifecyclereducer to ignore stale/duplicate legs, converge after reattach, and settle without restarting animations.Written for commit a4d3f81. Summary will update on new commits.