Skip to content

fix: generate Flask SECRET_KEY with a CSPRNG #963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rodriguescarson wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −4
Open

fix: generate Flask SECRET_KEY with a CSPRNG #963

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions dtale/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
from __future__ import absolute_import, print_function

import binascii
import getpass
import jinja2
import logging
import os
import numpy as np
import pandas as pd
import random
import socket
import string
import sys
import time
import traceback
Expand Down Expand Up @@ -296,10 +295,10 @@ def get_send_file_max_age(self, name):

def build_secret_key():
"""
Builds a string of 10 randomly chosen characters to be used as the Flask app's SECRET_KEY
Builds a cryptographically secure random string to be used as the Flask app's SECRET_KEY
"""

return "".join(np.random.choice(list(string.ascii_uppercase + string.digits), 10))
return binascii.hexlify(os.urandom(32)).decode("ascii")


def build_app(
Expand Down