Hunter/create 3d gift card - #711
Draft
hunterbecton wants to merge 3 commits into
Draft
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
hunterbecton
force-pushed
the
hunter/create-3d-gift-card
branch
from
October 6, 2025 17:47
1b149d6 to
cd30712
Compare
hunterbecton
force-pushed
the
hunter/create-3d-gift-card
branch
from
October 6, 2025 17:49
cd30712 to
8976221
Compare
hunterbecton
force-pushed
the
hunter/create-3d-gift-card
branch
from
October 6, 2025 17:55
8976221 to
5a3d490
Compare
jordanarldt
reviewed
Oct 16, 2025
|
|
||
| export interface GiftCardProps { | ||
| maxTilt?: number; | ||
| amount: string | null; |
Contributor
There was a problem hiding this comment.
Suggested change
| amount: string | null; | |
| balance: string | null; | |
| expiresAt?: string | null; | |
| expiresAtLabel?: string; | |
| status?: 'ACTIVE' | 'EXPIRED' | 'PENDING' | 'DISABLED'; |
Status and expires at will probably be catalyst specific, but figured i'd leave a comment anyways
Contributor
Author
There was a problem hiding this comment.
I think it's worth adding since we're not really thinking about the components as Catalyst-specific anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why
GiftCardwith 3D hover holo effect