fix: align Muse markers to sample clock and harden analysis epoching - #266
Merged
Merged
Conversation
jdpigeon
commented
Sep 18, 2026
jdpigeon
commented
Contributor
- Replace synchronizeTimestamp with injectMuseMarker/createRawMuseObservable that buffers {code, timestamp} and attaches markers to the sample whose interval contains the marker timestamp, bounding error to one sample.
- Add Muse driver tests mocking muse-js to cover marker alignment and NaN filtering without Web Bluetooth.
- Harden get_raw_epochs against recordings missing configured event codes: drop absent codes and return an empty EpochsArray when none match, instead of raising or silently relabeling.
- Update webworker PSD plotting to fall back to raw when clean_epochs is not loaded.
- Upgrade plotly.js (lockfile churn).
- Update import-experiments design doc to reflect the new Muse marker flow.
- Replace synchronizeTimestamp with injectMuseMarker/createRawMuseObservable
that buffers {code, timestamp} and attaches markers to the sample whose
interval contains the marker timestamp, bounding error to one sample.
- Add Muse driver tests mocking muse-js to cover marker alignment and NaN
filtering without Web Bluetooth.
- Harden get_raw_epochs against recordings missing configured event codes:
drop absent codes and return an empty EpochsArray when none match, instead
of raising or silently relabeling.
- Update webworker PSD plotting to fall back to raw when clean_epochs is not
loaded.
- Upgrade plotly.js (lockfile churn).
- Update import-experiments design doc to reflect the new Muse marker flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.