Rfc 1169 route manager async invokable - #11
Draft
BobrImperator wants to merge 6 commits into
Draft
Conversation
📊 Size reportTarball size — dist/dev -0.05%↓
dist/prod -0.04%↓
smoke-tests/v2-app-template/dist 0.3%↑
smoke-tests/v2-app-hello-world-template/dist No changes
🤖 This report was automatically generated by wyvox/pkg-size |
BobrImperator
force-pushed
the
rfc-1169-route-manager-async-invokable
branch
from
August 25, 2026 14:24
7807598 to
c85fe05
Compare
BobrImperator
commented
Aug 26, 2026
| this.invokable = INVOKABLES.get(bucket); | ||
| if (this.invokable === undefined) { | ||
| // Substate routes never 'enter' and don't initialize `getInvokablePromise` | ||
| const invokablePromise = routeInfo.getInvokablePromise ?? manager.getInvokable(bucket); |
Author
There was a problem hiding this comment.
Need to look for a better place to call the invokables for substates. Technically however, this is only a classicInterop feature.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.