Skip to content

Rfc 1169 route manager async invokable - #11

Draft
BobrImperator wants to merge 6 commits into
rfc-1169-route-managerfrom
rfc-1169-route-manager-async-invokable
Draft

Rfc 1169 route manager async invokable#11
BobrImperator wants to merge 6 commits into
rfc-1169-route-managerfrom
rfc-1169-route-manager-async-invokable

Conversation

@BobrImperator

Copy link
Copy Markdown

No description provided.

@github-actions

github-actions Bot commented Aug 24, 2026

Copy link
Copy Markdown

📊 Size report

Tarball size1.2 MB1.2 MB

dist/dev   -0.05%↓

File Before (Size / Brotli) After (Size / Brotli)
./packages/@ember/-internals/routing/route-managers/classic/manager.js 10.7 kB / 3 kB 6%↑11.4 kB / 4%↑3.1 kB
./packages/@ember/-internals/routing/route-managers/classic/substates.js 8.4 kB / 2.2 kB -33.7%↓5.6 kB / -27.8%↓1.6 kB
./packages/@ember/-internals/routing/route-managers/outlet-state.js 915 B / 384 B 72%↑1.6 kB / 46%↑560 B
./packages/@ember/routing/router-service.js 27.6 kB / 5.8 kB -0.63%↓27.4 kB / -0.24%↓5.7 kB
./packages/router_js/index.js 66.2 kB / 14.4 kB 0.6%↑66.5 kB / 0.04%↑14.4 kB
./packages/shared-chunks/api-{hash}.js 26.2 kB / 5.8 kB -72.1%↓7.3 kB / -61.4%↓2.3 kB
./packages/shared-chunks/transition-{hash}.js 17 kB / 4.4 kB 1%↑17.3 kB / 2%↑4.5 kB
Total (Includes all files) 2.1 MB / 504.1 kB -0.05%↓2.1 MB / -0.06%↓503.8 kB

dist/prod   -0.04%↓

File Before (Size / Brotli) After (Size / Brotli)
./packages/@ember/-internals/routing/route-managers/classic/manager.js 9.7 kB / 2.6 kB 7%↑10.3 kB / 4%↑2.7 kB
./packages/@ember/-internals/routing/route-managers/classic/substates.js 8.2 kB / 2.1 kB -34.7%↓5.3 kB / -28.3%↓1.5 kB
./packages/@ember/-internals/routing/route-managers/outlet-state.js 915 B / 382 B 72%↑1.6 kB / 47%↑560 B
./packages/@ember/routing/router.js 47.4 kB / 11.4 kB 0.4%↑47.6 kB / 0.1%↑11.5 kB
./packages/router_js/index.js 66.2 kB / 14.4 kB 0.6%↑66.5 kB / 0.03%↑14.4 kB
./packages/shared-chunks/transition-{hash}.js 16.6 kB / 4.3 kB 1%↑16.8 kB / 2%↑4.4 kB
Total (Includes all files) 1.9 MB / 461.3 kB -0.04%↓1.9 MB / -0.06%↓461 kB

smoke-tests/v2-app-template/dist   0.3%↑

File Before (Size / Brotli) After (Size / Brotli)
./assets/api-{hash}.js 296.7 kB / 79.7 kB 0.3%↑297.6 kB / 0.1%↑79.8 kB
Total (Includes all files) 348.9 kB / 96.8 kB 0.3%↑349.8 kB / 0.1%↑96.9 kB

smoke-tests/v2-app-hello-world-template/dist   No changes

File Before (Size / Brotli) After (Size / Brotli)
Total (Includes all files) 132.6 kB / 37.1 kB 132.6 kB / 37.1 kB

🤖 This report was automatically generated by wyvox/pkg-size

@BobrImperator
BobrImperator force-pushed the rfc-1169-route-manager-async-invokable branch from 7807598 to c85fe05 Compare August 25, 2026 14:24
this.invokable = INVOKABLES.get(bucket);
if (this.invokable === undefined) {
// Substate routes never 'enter' and don't initialize `getInvokablePromise`
const invokablePromise = routeInfo.getInvokablePromise ?? manager.getInvokable(bucket);

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to look for a better place to call the invokables for substates. Technically however, this is only a classicInterop feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant