Repository navigation
deps: bump jsdom from 28.1.0 to 29.1.1 in /frontend - #51
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #45 ( Dependabot 的 jsdom 30.1.1 升级因 CI 不兼容被搁置,本 PR 改为升级到 29.x 系列)。
变更
jsdom:28.1.0→29.1.1(package.json + package-lock.json,仅此一项直接依赖)为什么不是 30.1.1
npm view jsdom@30.1.1 engines→^22.22.2 || ^24.15.0 || >=26.0.0:明确不支持 Node 20node-version: "20"(.github/workflows/ci.yml),且本次无 workflow scope 改动权限TypeError: webidl.util.markAsUncloneable is not a function—— jsdom 30 内部依赖了较新 Node 才有的node:utilAPI为什么 29.x 可用
npm view jsdom@29.1.1 engines→^20.19.0 || ^22.13.0 || >=24.0.0:兼容 CI 的 Node 20(实际拉取为最新 20.19.x)本地验证(Node 22.22.2,全新 npm install)
npm run test:123 files / 801 tests 全绿npm run lint:0 errors(11 条 warning 为存量,与本次无关)npm run typecheck:通过npm run build(--outDir仓库外):通过后续如需上 jsdom 30+,需先把 CI Frontend 作业升到 Node 22(需要 workflow 改动授权)。