Repository navigation
Conversation
[Low impact] The changes since the previous review appear safe to merge. Reviews (2) · Last reviewed commit: "Document bloom property mutation witness..." · Reviewed by Greptile |
heemankv
marked this pull request as ready for review
October 23, 2026 06:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
cargo build --manifest-path .oss-verify/fuzz/Cargo.toml --bin event_bloom— passed.addand both query methods executed four times each;finalizeexecuted three times.ff 01 5aseed abort, confirming that both checks can detect a violation.cargo fmt --manifest-path .oss-verify/fuzz/Cargo.toml -- --check— passed.tools/validate.py projects/madara— passed with a temporary test manifest. The security contact is still required for the real manifest.tools/check --no-shell --twice madara— passed: plain, UB-check, AddressSanitizer, and combined binaries were byte identical across two clean builds.Enrollment follow-up
The OSS Verify enrollment instructions require a separate PR to
theorem-labs/oss-verifywithprojects/madara/project.yaml. That manifest needs a maintainer security contact and the enrolling maintainer's acceptance of the program terms. This PR supplies the Madara-hosted build files for it.