[Optimize][Clay] Reconcile early exposure targets - #8841
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c1e89de098
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| page_view_->page_view()->SendGlobalExposureEvent(); | ||
| return true; | ||
| } | ||
| if (!observer->TryNotifyAppearWithoutGeometry()) { |
There was a problem hiding this comment.
When a direct PageView child registers uiappear before insertion but has zero-sized or offscreen bounds, the normal OnAttach geometry check correctly leaves it unexposed, but this call unconditionally invokes NotifyExposureEvent(true) without checking intersection. Because the feature is enabled by default, such a child emits a false uiappear and any configured global exposure event, enters kExposed, and may then emit an immediate uidisappear on the next geometry check despite never having been visible.
Useful? React with 👍 / 👎.
c1e89de to
de43058
Compare
- Notify eligible direct PageView children on first attachment and reconcile deferred candidates when the host becomes visible. - Reconcile large observed descendants after their layout chain becomes ready while preserving existing geometry and frame-scan fallbacks. - Keep the behavior self-contained without temporary trace instrumentation, test-only changes, or new runtime service dependencies. TEST: clang-format and git diff --check; repository pre-push checks. AutoLand: release/4.2
de43058 to
7e64bec
Compare
2 participants
No description provided.