Skip to content

fix: remove unnecessary finalize and add copy in First generator #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TStylman wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: remove unnecessary finalize and add copy in First generator #149

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c048d3b
remove unnecessary finalize call from Event.evaluate() and copy paylo…
TStylman Sep 4, 2026
17dbeb1
remove unused import
TStylman Sep 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions lukefi/metsi/core/generators.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from lukefi.metsi.core.condition import Condition
from lukefi.metsi.core.db_utils import output_node_to_db
from lukefi.metsi.core.exceptions import MetsiException
from lukefi.metsi.core.model import ComputationalUnit, Finalizable
from lukefi.metsi.core.model import ComputationalUnit
from lukefi.metsi.core.operations import do_nothing
from lukefi.metsi.core.simulation_payload import SimulationPayload
from lukefi.metsi.core.treatment import Treatment
Expand Down Expand Up @@ -114,7 +114,7 @@ def evaluate(self,
node: int = 0) -> Generator[SimulationPayload[T], None, None]:
stop = False
for child in self.children:
gen = child.evaluate(payload, db, node)
gen = child.evaluate(copy(payload), db, node)
for leaf in gen:
yield leaf
stop = True
Expand Down Expand Up @@ -257,9 +257,6 @@ def evaluate(self,
new_collected_data,
self.tags | self.treatment.default_tags)

if isinstance(new_payload.unit, Finalizable):
new_payload.unit.finalize()

yield new_payload

@override
Expand Down
Loading