Adds receipt icon - #974
Merged
ericfennis merged 6 commits intoApr 8, 2023
Merged
Conversation
jguddas
reviewed
Mar 3, 2023
karsa-mistmere
commented
Mar 3, 2023
jguddas
reviewed
Mar 3, 2023
| stroke-linecap="round" | ||
| stroke-linejoin="round" | ||
| > | ||
| <path d="M4 2v20l2-1 2 1 2-1 2 1 2-1 2 1 2-1 2 1V2l-2 1-2-1-2 1-2-1-2 1-2-1-2 1-2-1Z" /> |
Member
There was a problem hiding this comment.
Suggested change
| <path d="M4 2v20l2-1 2 1 2-1 2 1 2-1 2 1 2-1 2 1V2l-2 1-2-1-2 1-2-1-2 1-2-1-2 1-2-1Z" /> | |
| <path d="M4 2v20l2-1 2 1 2-1 2 1 2-1 2 1 2-1 2 1V2l-2 1-2-1-2 1-2-1-2 1-2-1-2 1-2-1" /> |
There is also this svg/svgo#1751
Member
Author
There was a problem hiding this comment.
In this instance a closepath command is preferable, I think, since we don't want any potential for two line caps in a closed path.
Member
There was a problem hiding this comment.
You can remove the zero witdth close path command there as long as the line cap is round, but keeping it is also 100% fine.
Contributor
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
ericfennis
approved these changes
Apr 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #615