[pentest] Make Target.read_response respect attempt retries - #31003
Merged
luismarques merged 1 commit intoAug 14, 2026
Merged
Conversation
AlexJones0
approved these changes
Aug 14, 2026
AlexJones0
left a comment
AlexJones0
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this seems reasonable to me. See my comment - I'd be a little concerned about losing meaningful data, so if this is the problem, we should try and determine why we are seeing the error and how we might recover. But indeed, defaulting to lose the response altogether as the current implementation does is not particularly helpful.
luismarques
force-pushed
the
pentest-targets-read_response-retries
branch
from
August 14, 2026 11:53
805e50e to
bcdd1b0
Compare
Ensure that empty or corrupted responses don't circumvent the requested number of attempts, similar to other methods. Signed-off-by: Luís Marques <luismarques@lowrisc.org>
luismarques
force-pushed
the
pentest-targets-read_response-retries
branch
from
August 14, 2026 12:42
bcdd1b0 to
e3ab1a0
Compare
AlexJones0
approved these changes
Aug 14, 2026
AlexJones0
left a comment
AlexJones0
left a comment
Contributor
There was a problem hiding this comment.
Thanks, seems reasonable to me.
Contributor
Author
|
Only the flaky tests failed, so I'll merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensure that empty or corrupted responses don't circumvent the requested number of attempts, similar to other methods.