[rram_ctrl] remove flash ctrl from EarlGrey - #30913
Open
gautschimi wants to merge 17 commits into
Open
Conversation
gautschimi
requested review from
engdoreis and
hcallahan-lowrisc
and removed request for
a team
August 4, 2026 08:30
gautschimi
marked this pull request as draft
August 4, 2026 08:30
gautschimi
force-pushed
the
remove_flash_ctrl
branch
3 times, most recently
from
August 13, 2026 15:02
47842d7 to
542c061
Compare
gautschimi
marked this pull request as ready for review
August 13, 2026 15:28
gautschimi
removed request for
a team,
cfrantz,
engdoreis and
hcallahan-lowrisc
August 13, 2026 15:28
gautschimi
force-pushed
the
remove_flash_ctrl
branch
10 times, most recently
from
August 14, 2026 16:56
2d43806 to
e02d829
Compare
gautschimi
force-pushed
the
remove_flash_ctrl
branch
from
August 14, 2026 18:33
e02d829 to
edc19c5
Compare
Signed-off-by: Michael Gautschi <mgautschi@lowrisc.org>
Signed-off-by: Michael Gautschi <mgautschi@lowrisc.org>
Signed-off-by: Michael Gautschi <mgautschi@lowrisc.org>
gautschimi
force-pushed
the
remove_flash_ctrl
branch
from
August 14, 2026 18:48
edc19c5 to
11fdf37
Compare
Contributor
Author
|
flash_ctrl is too big, verible lint fails because of too many deletions. The biggest contributors are autogen files: Shall I try to split it up somehow or is it ok? @andreaskurth |
gautschimi
force-pushed
the
remove_flash_ctrl
branch
3 times, most recently
from
August 15, 2026 18:08
878b024 to
d6e15ab
Compare
This includes: - sleep_pin_wake_test - rv_dm_ndm_reset_req - modify_digest - irq_asm - spi_device_unittest Signed-off-by: Michael Gautschi <mgautschi@lowrisc.org>
There were a few tests that actually do not have a dependency on flash, but still had flash_ctrl in its dependency tree. spi_device was ported to use nvm_ctrl instead of flash_ctrl Signed-off-by: Michael Gautschi <mgautschi@lowrisc.org>
Removing flash_ctrl removes 5 alerts and 6 interrupts. Signed-off-by: Michael Gautschi <mgautschi@lowrisc.org>
Signed-off-by: Michael Gautschi <mgautschi@lowrisc.org>
These tests need to be ported to use mock_rram_ctrl instead of mock_flash_ctrl. With flash_ctrl removed, they don't build anymore. Signed-off-by: Michael Gautschi <mgautschi@lowrisc.org>
Flash has been removed for earlgrey. It can no longer be accessed by the bkdr loader. Signed-off-by: Michael Gautschi <mgautschi@lowrisc.org>
This commit adds a first version of the rram_exc_handler. The content of the rram_exc_handler will need to be further developement (lowRISC#31010). This commit also renames the flash_ecc_exc_handler_en to nvm_ecc_exc_handler_en and puts the rram/flash_exc_handler at the location of nvm_exception_handler. Signed-off-by: Michael Gautschi <mgautschi@lowrisc.org>
Signed-off-by: Michael Gautschi <mgautschi@lowrisc.org>
flash_ctrl has been removed, the flash bkdr targets are no longer available. Signed-off-by: Michael Gautschi <mgautschi@lowrisc.org>
Everything is loaded into RRAM. This also removes the flash_ctrl test from the verilotor testsuite as it can not pass anymore without flash_ctrl. Signed-off-by: Michael Gautschi <mgautschi@lowrisc.org>
This section did not yet deduct the reserved_bytes per slot. Signed-off-by: Michael Gautschi <mgautschi@lowrisc.org>
This test tries to execute from uninitialized memory. Instead of relying on a all-one(flash) or all-zero(RRAM) pattern for uninitialized words, explicitly write the first and last position of the image with an all-one pattern that will lead to an illegal instruction. Signed-off-by: Michael Gautschi <mgautschi@lowrisc.org>
The alerts checks/triggers for the RRAM alerts are currently empty. This is tracked in issue: (lowRISC#31009) Signed-off-by: Michael Gautschi <mgautschi@lowrisc.org>
gautschimi
force-pushed
the
remove_flash_ctrl
branch
from
August 15, 2026 18:17
d6e15ab to
a90d738
Compare
The flash_ctrl references have been removed as RRAM is the only remaining NVM in Earl Grey. The section about system reset handling with RRAM has been updated but will need to be implemented in RTL (lowRISC#31015) Signed-off-by: Michael Gautschi <mgautschi@lowrisc.org>
gautschimi
requested review from
andreaskurth,
glaserf,
nasahlpa,
thommythomaso and
vogelpi
and removed request for
a team
August 15, 2026 18:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As per RFC , Earlgrey will be extended with support for RRAM based non-volatile memory.
This 7th integration PR removes flash_ctrl from Earl Grey and fixes remaining dependencies.
The following is done in this PR:
flash_ctrl_mem_protection_test_fpga_cw340_rom_with_fake_keysflash_ctrl_write_clear_test_fpga_cw340_sival_rom_extflash_ctrl_info_access_lc_*_fpga_cw340_sivalflash_ctrl_idle_low_power_test_fpga_cw340_sival_rom_extflash_ctrl_idle_low_power_test_fpga_cw340_rom_with_fake_keysflash_ctrl_ops_testflash_ctrl_clock_freqs_testflash_ctrl_testmock_rramare excluded:bootstrap_unittestbootstrap_fuzz_testbootstrap_unittest_utilbootstrap_fuzzer_utilflash_exec_unittestisfb_unittestchip_prim_tl_accesschip_sw_flash_initchip_sw_inject_scramble_seedall_escalation_reset_testchip_sw_rom_e2e_asm_initrom_epmp_testspi_device.c,spi_device_test.cmodify_digest.cirq_asm.Srv_dm_ndm_reset_req.cflash_ctrl_c_regs.h, anddif_flash_ctrl.h,flash_ctrl.hrram_exc_handler.