Correction for output mediator passed to WriteHeader #5184 - #5186
Merged
Conversation
ExportEvents passed the plaso.output.mediator module to WriteHeader instead of the OutputMediator instance, causing psort.py -o kml to fail with an AttributeError. Also adds an end-to-end test for the kml output format. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5186 +/- ##
=======================================
Coverage 85.10% 85.10%
=======================================
Files 456 456
Lines 41089 41089
=======================================
Hits 34967 34967
Misses 6122 6122 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Thanks for the proposed changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5184.
ExportEventspassed theplaso.output.mediatormodule toWriteHeaderinstead ofthe
OutputMediatorit had just created, sopsort.py -o kmlfailed withAttributeError: module 'plaso.output.mediator' has no attribute 'encoding'.Also adds the end-to-end test for the
kmloutput format, modelled onoutput_rawpy.A note on the reference output:
KMLOutputModule.WriteFieldValuesreturns early forevents without latitude and longitude, and
test_data/psort_test.plasohas nogeolocation data, so
test_data/end_to_end/kml.logis the header and footer only:That covers the defect, since it is in
WriteHeader. It does not cover the placemarkpath in
WriteFieldValues, and there is currently no clean way to:android_airtagappears to be the only parser that populates
latitudeandlongitude, and theAirGuard
beacontable it reads stores latitude in the column namedlongitudeandlongitude in the column named
latitude(reference). The plugin
does not compensate for that, so a placemark reference generated from
test_data/android/attd_dbwould record reversed coordinates. Noted for the record,not addressed here.
Verified with the full end-to-end suite on Ubuntu 26.04, exit 0, including the new
output_kmlcase.