Skip to content

Fix: deg/rad unit mismatch in removeProjections corrupts chunked helical FBP #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zezisme wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: deg/rad unit mismatch in removeProjections corrupts chunked helical FBP #214

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/parameters.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2252,7 +2252,8 @@ bool parameters::removeProjections(int firstProj, int lastProj)
if (phis_full != NULL)
delete[] phis_full;
phis_full = new float[numAngles];
get_angles(phis_full);
for (int i = 0; i < numAngles; i++)
phis_full[i] = phis[i]; // radians
phis_new = new float[numAngles_new];
for (int i = firstProj; i <= lastProj; i++)
phis_new[i - firstProj] = phis_full[i];
Expand Down Expand Up @@ -2287,11 +2288,11 @@ bool parameters::removeProjections(int firstProj, int lastProj)
}
if (phis_new != NULL)
{
float phi_start_save = phi_start;
float phi_end_save = phi_end;
set_angles(phis_new, numAngles_new);
phi_start = phi_start_save;
phi_end = phi_end_save;
delete[] phis;
phis = phis_new;
phis_new = NULL;
phi_start = min(phis[0], phis[numAngles_new - 1]);
phi_end = max(phis[0], phis[numAngles_new - 1]);
angularRange = angularRange_save;
}
numAngles = numAngles_new;
Expand Down