Skip to content

Check database compatibility with KeePassXC in both directions - #343

Merged
lixmal merged 1 commit into
masterfrom
keepassxc-compat
Aug 26, 2026
Merged

lixmal merged 1 commit into
masterfrom
keepassxc-compat

Conversation

@lixmal

@lixmal lixmal commented Aug 26, 2026

Copy link
Copy Markdown
Owner

Now that the app writes to the database, a saved file has to stay a file other KeePass clients can read, and a file they wrote has to stay one this app can open. The specs drive the app through the browser and check the file itself with keepassxc-cli.

  • Create an entry through the UI, save it, and read the title, username and password back with keepassxc-cli, asserting the entries that were already there survived the rewrite
  • Add an entry with keepassxc-cli and open it in the app
  • Compare the KDF and cipher before and after a save, so a weaker one after writing shows up as a failure
  • Run them against a second instance on a copy of the fixture, so writing specs cannot disturb the ones that only read
  • Install keepassxc-cli in the e2e job; the specs skip themselves where it is missing, so a local run without it still works

One thing they do not cover yet: a database written here makes KeePassXC log KdbxXmlReader::readDatabase: found unused key "0" on every open, which the original file does not. Nothing is lost and everything reads back, so it is not asserted against, but the writer leaves a binary in the pool that no entry references and that belongs in keepass-rs.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 38 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: aec003cc-48de-44fd-9510-322186a3ca8b

📥 Commits

Reviewing files that changed from the base of the PR and between 7775d1c and a2b0664.

📒 Files selected for processing (5)
  • .github/workflows/test.yml
  • .gitignore
  • playwright.config.js
  • tests/config.compat.yml
  • tests/e2e/keepassxc-compat.spec.js

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lixmal
lixmal merged commit 65731fc into master Aug 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant