Skip to content

Allow the kernel keyring to be turned off where the syscalls are blocked - #342

Merged
lixmal merged 1 commit into
masterfrom
use-keyring-toggle
Aug 26, 2026
Merged

lixmal merged 1 commit into
masterfrom
use-keyring-toggle

Conversation

@lixmal

@lixmal lixmal commented Aug 26, 2026

Copy link
Copy Markdown
Owner

#316 rebased onto the key store from #311, which is now on master, plus the two things a downgrade switch needs to be honest about itself. Original commit by @allamiro.

  • Add use_keyring, defaulting to true, so Linux keeps the kernel keyring unless it is deliberately turned off
  • Fall back to the in-memory key store when it is off, for runtimes that block keyctl, add_key and request_key and where a seccomp profile is not an option
  • Warn on startup when the keyring is off, so the downgrade shows up in the log rather than only in a config file
  • Document it in the README next to the seccomp profile it is the fallback for

Verified with use_keyring: false: the warning appears, the database opens and serves groups through the in-memory store, and no keys are placed in the kernel keyring. The e2e suite passes with the default and the tests cover both stores.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 50 minutes.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c634a8de-7891-4c2d-a386-f11b1175c998

📥 Commits

Reviewing files that changed from the base of the PR and between 5c67973 and 487303f.

📒 Files selected for processing (7)
  • README.md
  • config.yml
  • src/config/config.rs
  • src/keepass/keepass.rs
  • src/keepass/key.rs
  • src/server/route/util.rs
  • src/server/server.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@lixmal
lixmal merged commit eed564f into master Aug 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant