Skip to content

fix(telemetry): log a warning when the audio recording can't be read at upload time #6833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
longcw merged 2 commits into from
Aug 17, 2026
+7 −1
Merged

fix(telemetry): log a warning when the audio recording can't be read at upload time #6833

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbae689
fix(telemetry): log a warning when the audio recording can't be read …
dubbl-a Aug 13, 2026
a92e86b
fix(telemetry): use exc_info for the audio read failure warning
dubbl-a Aug 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion livekit-agents/livekit/agents/telemetry/traces.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,8 +685,14 @@ def _log(
try:
async with aiofiles.open(report.audio_recording_path, "rb") as f:
audio_bytes = await f.read()
except Exception:
except Exception as e:
audio_bytes = b""
logger.warning(
"failed to read audio recording for session report upload, "
"uploading without the audio part (path=%s): %s",
report.audio_recording_path,
e,

@longcw longcw Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you use exc_info=e instead of %s?

@dubbl-a dubbl-a Aug 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks. Switched to exc_info=e and kept the path in the message, so the traceback comes through now instead of just str(e).

)

url = f"{observability_url}/observability/recordings/v0"

Expand Down