-
Notifications
You must be signed in to change notification settings - Fork 3.5k
feat(gnani): add X-Source/X-API-Request-ID headers and widen audio co… #6743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Gnani-AI-Mintlify
wants to merge
1
commit into
livekit:main
Choose a base branch
from
Gnani-AI-Mintlify:feat/gnani-source-attribution
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
24 changes: 24 additions & 0 deletions
24
livekit-plugins/livekit-plugins-gnani/livekit/plugins/gnani/request_id.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| # Copyright 2025 LiveKit, Inc. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| """Request ID generation for Gnani API correlation.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import uuid | ||
|
|
||
|
|
||
| def _generate_request_id() -> str: | ||
| """Generate a unique request ID for outbound Gnani API calls.""" | ||
| return f"lk_req_{uuid.uuid4().hex[:12]}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Newly allowed mu-law/A-law audio formats produce broken or silent speech output
Mu-law and A-law audio formats are now offered as valid choices (
GnaniTTSEncodings/GnaniTTSContainersatlivekit-plugins/livekit-plugins-gnani/livekit/plugins/gnani/models.py:54-55) even though the playback path cannot interpret them, so anyone selecting them hears noise or nothing at all.Impact: Users who pick the newly advertised telephony audio formats get garbled or missing agent speech.
How the container string flows into the audio emitter and decoder
_mime_type()inlivekit-plugins/livekit-plugins-gnani/livekit/plugins/gnani/tts.py:249-252maps any container other thanrawtoaudio/<container>, producingaudio/mulaw/audio/alaw.AudioEmitter.initialize(livekit-agents/livekit/agents/tts/tts.py:883-888) only treatsaudio/pcmandaudio/rawas raw PCM, so these are sent toAudioStreamDecoder, whose MIME→libav table (livekit-agents/livekit/agents/utils/codecs/decoder.py:46-62) has no entry for mu-law/A-law; PyAV then has to auto-detect a headerless G.711 stream, which fails.The other combination is equally broken:
encoding="pcm_mulaw"withcontainer="raw"yieldsaudio/pcm, so 8-bit companded samples are pushed through as 16-bit linear PCM (sample_widthstays 2 inGnaniTTSOptions), producing loud noise at half the expected duration.Supporting these formats requires decoding G.711 to linear PCM in the plugin (or restricting the literals) rather than just widening the type unions.
Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.