fix(cartesia): narrow aligned_transcript when timestamps unsupported (#6493) - #6735
Open
dorukdumlu wants to merge 1 commit into
Open
fix(cartesia): narrow aligned_transcript when timestamps unsupported (#6493)#6735dorukdumlu wants to merge 1 commit into
dorukdumlu wants to merge 1 commit into
Conversation
…ivekit#6493) Cartesia warned on unsupported model/language combos but still advertised capabilities.aligned_transcript=True, which made use_tts_aligned_transcript expect timed text that never arrives. Clear the capability (and skip add_timestamps) when the config cannot deliver, and re-evaluate on update_options.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
capabilities.aligned_transcriptto model/language combos that can actually deliver word timestamps (en/de/es/fr on sonic models; all languages on preview models), instead of mirroring theword_timestampsrequest flag.update_optionswhen model/language changes, and skipadd_timestampsin the WS payload when unsupported.Fixes #6493
Notes
sync_alignmenthas no published model/language restriction matrix comparable to Cartesia's, so its capability stays tied to the request flag. Happy to extend if there's a known unsupported combo.TimedStringarrives) are out of scope here — that needs a separate fallback path ingeneration.py/agent_activity.py.Test plan
pytest tests/test_plugin_cartesia_tts.py --plugin cartesia(11 passed)language="ja",sonic-3,word_timestamps=True) no longer triggersuse_tts_aligned_transcript is enabled but no agent transcript was returned from ttswhen aligned transcripts are enabled on the sessionen) still requests timestamps and keepsaligned_transcript=True