fix(google): replay Gemini realtime tool result across session restart - #6481
Open
ByteMaster-1 wants to merge 3 commits into
Open
fix(google): replay Gemini realtime tool result across session restart#6481ByteMaster-1 wants to merge 3 commits into
ByteMaster-1 wants to merge 3 commits into
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ByteMaster-1
force-pushed
the
fix/gemini-realtime-tool-update
branch
from
July 18, 2026 14:29
b16c719 to
30dea9c
Compare
ronanmcnulty
pushed a commit
to GreyhoundRecyclingIreland/agents
that referenced
this pull request
Jul 23, 2026
Routine + handled on our deployment: post-completion re-emissions are dropped by design (livekit#6431/livekit#6481) and the worker's capture wrap folds the text into the stored transcript before this handler runs. The WARNING paged Rollbar on essentially every Gemini call (cai items livekit#1543/livekit#1544, livekit#1606/livekit#1607).
ByteMaster-1
force-pushed
the
fix/gemini-realtime-tool-update
branch
from
July 31, 2026 09:22
30dea9c to
87e3efe
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
ByteMaster-1
force-pushed
the
fix/gemini-realtime-tool-update
branch
from
August 11, 2026 14:47
1730cca to
0523c25
Compare
When update_tools() restarts the Gemini Live websocket mid-turn, a function-tool result produced in that window was sent on the closing session and never replayed, so the model never received it and the turn hung. Buffer the tool result whenever there is no live socket to send on (no active session, or a restart pending) and replay it via send_tool_response once the new session is established. Gemini Live auto-generates a reply after a function response, so no extra user-turn nudge is sent. Multiple results landing during one reconnect window are accumulated so none are dropped. Also decouple generation-completion handling from the model name so newer Live preview models work: track generation state explicitly via _generation_completed, drop trailing model_turn frames that arrive with no active generation, and allow generate_reply() for models without mutable_chat_context (gated on the capability, not a model-name literal). Fixes livekit#6479 Co-Authored-By: heer <heer434@users.noreply.github.com>
ByteMaster-1
force-pushed
the
fix/gemini-realtime-tool-update
branch
from
August 11, 2026 20:03
0523c25 to
2805b2a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Restrict tool-result buffering to a genuine restart window (track whether a session was ever established) so the initial context sync / agent handoff no longer resends historical function outputs. Strip only the stray model_turn in the recv guard instead of dropping the whole message, so bundled turn_complete/usage/go_away/resumption events are still handled.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
The guard's condition (generation done AND not _generation_completed) was unreachable — every path that marks a generation done sets the flag True first — so it never fired and processing was unchanged. Remove it and the dead _generation_completed state rather than ship code that implies a protection it never provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When update_tools() restarts the Gemini Live websocket mid-turn, a function-tool result produced in that window was sent on the closing session and never replayed, so the model never received it and the turn hung. Buffer the tool result while the socket is restarting and replay it via send_tool_response once the new session is established, then nudge the model to continue the turn.
Also decouple generation-completion handling from the model name so newer Live preview models work: track generation state explicitly via _generation_completed, drop trailing model_turn frames that arrive with no active generation, and allow generate_reply() for models without mutable_chat_context (gated on the capability, not a model-name literal). Fixes #6479