-
Notifications
You must be signed in to change notification settings - Fork 3.6k
fix(deps): update third party deps (major) #6268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
renovate
wants to merge
1
commit into
main
Choose a base branch
from
renovate/major-third-party-deps
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2
−2
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Agents can no longer use MCP tool servers after the dependency jump
The MCP tool-server dependency is moved to a new major line (
mcp>=2, <3atlivekit-agents/pyproject.toml:64) without updating the code that talks to it, so every agent that connects to an MCP tool server fails to start.Impact: Any agent using MCP tools breaks immediately with a confusing "install the mcp package" error, even though the package is installed.
Incompatible v1 client APIs used against the mcp 2.x SDK
Inspecting the published
mcp2.0.0 wheel shows several v1 APIs used bylivekit-agents/livekit/agents/llm/mcp.pyare gone or changed:GetSessionIdCallbackno longer exists anywhere in the package, sofrom mcp.client.streamable_http import GetSessionIdCallback, streamable_http_client(livekit-agents/livekit/agents/llm/mcp.py:27) raisesImportError, which the surroundingtry/except ImportError(livekit-agents/livekit/agents/llm/mcp.py:29-33) converts into the misleading "The 'mcp' package is required ... pip install 'livekit-agents[mcp]'" message. This alone makes all MCP usage unusable.httpx2, nothttpx:sse_client/streamable_http_clientexpect anhttpx2.AsyncClient(andsse_clientcallsclient.sse(url)), while_create_http_client(livekit-agents/livekit/agents/llm/mcp.py:388-405) builds anhttpx.AsyncClient.ClientSession(read_timeout_seconds=...)is nowfloat | None(notimedeltahandling remains in the package; the value is passed straight toanyio.fail_after), butlivekit-agents/livekit/agents/llm/mcp.py:158still passestimedelta(seconds=...).mcp.server.fastmcpwas removed, breakingexamples/voice_agents/mcp/server.py:4.Either keep the
<2bound or portllm/mcp.py(and the example server) to the v2 client API.Prompt for agents
Was this helpful? React with 👍 or 👎 to provide feedback.