Repository navigation
WF-1097: Add chat_ids filter to ListArchives - #272
Merged
Merged
Conversation
michal-treter-text
force-pushed
the
codex/add-chat-ids-archive-filter
branch
from
September 25, 2026 06:49
afc8991 to
7da5a40
Compare
michal-treter-text
marked this pull request as ready for review
September 25, 2026 06:58
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The implementation matches the described API contract and includes focused coverage for both required behaviors.
Review effort: Balanced
Findings: None
What changed in this PR
Adds chat ID filtering to ListArchives.
Changes:
- Adds
ByChatswithchat_idsJSON serialization. - Tests serialization and clearing by
ByThreads.
| File | Description |
|---|---|
agent/filters.go |
Adds the chat ID filter field and builder method. |
agent/filters_test.go |
Verifies serialization and filter-clearing behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
wfabjanczuk
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests