Skip to content

[Ascend] Fix missing accum_dtype param in fused_linear_jsd forward - #1367

Open
TecJesh wants to merge 1 commit into
linkedin:mainfrom
TecJesh:fix_linear_jsd
Open

[Ascend] Fix missing accum_dtype param in fused_linear_jsd forward#1367
TecJesh wants to merge 1 commit into
linkedin:mainfrom
TecJesh:fix_linear_jsd

Conversation

@TecJesh

@TecJesh TecJesh commented Aug 11, 2026

Copy link
Copy Markdown

Summary

Fix TypeError in Ascend backend's LigerFusedLinearJSDFunction.forward() caused by a missing accum_dtype parameter.
When running the fused_linear_jsd test on Ascend NPU, the following error occurs:
TypeError: LigerFusedLinearJSDFunction.forward() takes from 5 to 9 positional arguments but 10 were given
Add the missing accum_dtype: Optional[torch.dtype] = None parameter in three locations within backends/_ascend/ops/fused_linear_jsd.py

Testing Done

image
  • Hardware Type: Atlas 800I A2
  • run make test to ensure correctness
  • run make checkstyle to ensure code style
  • run make test-convergence to ensure convergence

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant