[Ascend] Fix missing accum_dtype param in fused_linear_jsd forward - #1367
Open
TecJesh wants to merge 1 commit into
Open
[Ascend] Fix missing accum_dtype param in fused_linear_jsd forward#1367TecJesh wants to merge 1 commit into
TecJesh wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
TypeErrorin Ascend backend'sLigerFusedLinearJSDFunction.forward()caused by a missingaccum_dtypeparameter.When running the fused_linear_jsd test on Ascend NPU, the following error occurs:
TypeError: LigerFusedLinearJSDFunction.forward() takes from 5 to 9 positional arguments but 10 were given
Add the missing
accum_dtype: Optional[torch.dtype] = Noneparameter in three locations withinbackends/_ascend/ops/fused_linear_jsd.pyTesting Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence