[NPU] align fused linear JSD forward with accum_dtype API - #1346
Open
zheliuyu wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
@Tcc0403 This PR is ready for review. Thanks. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upstream #1322 added
accum_dtypeto fused linear JSD (LigerFusedLinearJSD,LigerFusedLinearJSDFunction.apply). On NPU,liger_kernel.opsresolves to the Ascend backend, whoseLigerFusedLinearJSDFunction.forwardstill used the old signature. Alltest/transformers/test_fused_linear_jsd.pycases failed with:TypeError: forward() takes from 5 to 9 positional arguments but 10 were givenThis PR updates
backends/_ascend/ops/fused_linear_jsd.pyto acceptaccum_dtype, pass it throughfused_linear_jsd_forward, and mirror the default path: optional fp32grad_weightaccumulation with cast back to weight dtype.backwardreturn tuple is extended by oneNonefor the new argument.Testing Done
make testto ensure correctnessmake checkstyleto ensure code stylemake test-convergenceto ensure convergence