Add requires-python >=3.10 to pyproject.toml - #1332
Open
yashb98 wants to merge 1 commit into
Open
Conversation
Without it, pip resolves and installs liger-kernel on any interpreter, so users on unsupported Pythons get runtime failures instead of a clean resolver message. The floor matches the project's CI: every test and release workflow runs Python 3.10. Fixes linkedin#1302
Author
|
Same as #1328, the workflow runs here are held at |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1302.
pyproject.tomlhas norequires-python, so pip resolves and installs liger-kernel on any interpreter. Users on unsupported Pythons get runtime failures instead of a clean "requires Python >= X" resolver message.This adds
requires-python = ">=3.10", matching the project's own floor: every CI test workflow (nvi-ci, amd-ci, checkstyle, benchmark) and the release-publish workflow run Python 3.10.Picking up the hand-off from #1307 (closed by its author due to inactivity, fix noted as still valid).
Testing Done
Metadata-only change. Verified the line parses and the floor matches CI: