Skip to content

Add requires-python >=3.10 to pyproject.toml - #1332

Open
yashb98 wants to merge 1 commit into
linkedin:mainfrom
yashb98:requires-python-310
Open

Add requires-python >=3.10 to pyproject.toml#1332
yashb98 wants to merge 1 commit into
linkedin:mainfrom
yashb98:requires-python-310

Conversation

@yashb98

@yashb98 yashb98 commented Aug 2, 2026

Copy link
Copy Markdown

Summary

Fixes #1302.

pyproject.toml has no requires-python, so pip resolves and installs liger-kernel on any interpreter. Users on unsupported Pythons get runtime failures instead of a clean "requires Python >= X" resolver message.

This adds requires-python = ">=3.10", matching the project's own floor: every CI test workflow (nvi-ci, amd-ci, checkstyle, benchmark) and the release-publish workflow run Python 3.10.

Picking up the hand-off from #1307 (closed by its author due to inactivity, fix noted as still valid).

Testing Done

Metadata-only change. Verified the line parses and the floor matches CI:

$ python -c "import tomllib; print(tomllib.load(open('pyproject.toml','rb'))['project']['requires-python'])"
>=3.10

Without it, pip resolves and installs liger-kernel on any interpreter,
so users on unsupported Pythons get runtime failures instead of a clean
resolver message. The floor matches the project's CI: every test and
release workflow runs Python 3.10.

Fixes linkedin#1302
@yashb98

yashb98 commented Aug 5, 2026

Copy link
Copy Markdown
Author

Same as #1328, the workflow runs here are held at action_required and have never run. Could a maintainer approve them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pyproject.toml has no requires-python — pip installs on any interpreter; publish workflows disagree (3.8 vs 3.10)

1 participant