ci: wire GPU checks to patched vLLM nightly image - #183
Merged
Conversation
Signed-off-by: Yubo Wang <yubowang2019@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The GPU CI dispatcher currently launches with
VLLM_USE_V2_MODEL_RUNNER=1, but the nightly Docker publisher still builds the old v0.22.1 image. That image does not support theextract_hidden_statesV2 path, causing the GPU smoke to fail during vLLM configuration before training starts.This PR:
nightly-<short-sha>-vllm-ppand movingnightly-vllm-pptags;TORCHSPEC_CI_IMAGEmust point to an ARM64.sqshmade fromnightly-vllm-pp.Validation
git diff --checkbash -n tools/ci/dispatch_slurm.sh tools/ci/gpu_2gpu.sbatchRequired post-merge infrastructure update
The repository secret
TORCHSPEC_CI_IMAGEmust be updated to the Inkwell ARM64.sqshimported fromlightseekorg/torchspec:nightly-vllm-pp. The new preflight will report the expected and actual image metadata if the old.sqshremains configured.