docs(dbt_orders): clarify partner analysis context in metric descriptions - #104
Open
lightdash[bot] wants to merge 1 commit into
Open
lightdash[bot] wants to merge 1 commit into
lightdash[bot] wants to merge 1 commit into
Conversation
…ions ## Summary - Updated descriptions for 7 metrics in `dbt_orders.yml` to clarify how each metric behaves when grouped by Partner - No changes to metric names, labels, SQL, or types — documentation only - Affected metrics: `count_distinct_order_id`, `count_of_order_id`, `sum_of_basket_total`, `average_of_basket_total`, `sum_of_profit`, `avg_profit`, `sum_of_partner_commission` ## Changes Each description now follows the pattern: what the metric measures overall, then an explicit note on what it shows when grouped by the Partner dimension. This makes partner-level analysis self-documenting in the Lightdash metric catalogue. ## Test plan - [ ] Lightdash compile: SUCCESS (exit 0, 5/5 explores) - [ ] Verify updated descriptions appear in the Lightdash metric picker for the Orders explore - [ ] Confirm no regressions on existing metric behaviour (names, types, SQL unchanged) Co-authored-by: lightdash[bot] <183517231+lightdash[bot]@users.noreply.github.com> Co-authored-by: Josh Elston-Green <josh@lightdash.com>
Lightdash Validation Results
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dbt_orders.ymlto clarify how each metric behaves when grouped by Partnercount_distinct_order_id,count_of_order_id,sum_of_basket_total,average_of_basket_total,sum_of_profit,avg_profit,sum_of_partner_commissionChanges
Each description now follows the pattern: what the metric measures overall, then an explicit note on what it shows when grouped by the Partner dimension. This makes partner-level analysis self-documenting in the Lightdash metric catalogue.
Test plan