Add support for overriding dnsConfig and dnsPolicy - #96
Merged
Merged
Conversation
CharlieDixon
suggested changes
Aug 29, 2025
CharlieDixon
left a comment
CharlieDixon
left a comment
Contributor
There was a problem hiding this comment.
Great idea to add support for this! Could you also add this configuration to the backendDeployment.yaml?
The reason being is that we don't use dedicated worker deployments for queries or scheduling tasks, so the application is running exclusively on backend-deployment pods at the time of writing.
Otherwise, these changes all LGTM 👌
nessex
force-pushed
the
nessex-dns-config
branch
from
August 30, 2025 01:11
f6b8475 to
25fe86a
Compare
Contributor
Author
|
Ah good catch, I've pushed that change 👍 just like tolerations and nodeSelectors, I've opted to have them share a config as I think these are most likely to be configured in a uniform way. |
CharlieDixon
approved these changes
Sep 1, 2025
owlas
approved these changes
Sep 3, 2025
Contributor
|
Approved great work @nessex ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT
Adds support for overriding
dnsConfiganddnsPolicyWHY
This allows overriding things like ndots and retries, to reduce redundant DNS traffic.