Skip to content

feat: report helm install type and chart version in telemetry env - #156

Merged
charliedowler merged 2 commits into
mainfrom
feature/spk-1089
Aug 18, 2026
Merged

charliedowler merged 2 commits into
mainfrom
feature/spk-1089

Conversation

@charliedowler

Copy link
Copy Markdown
Contributor

What

The chart now identifies itself to upgrade telemetry. Three guarded defaults land in the ConfigMaps:

  • LIGHTDASH_INSTALL_TYPE: helm (both ConfigMaps)
  • LIGHTDASH_HELM_CHART_VERSION: <chart version> (both ConfigMaps)
  • LIGHTDASH_MIGRATION_EXECUTION_MODE: helm-boot in the main ConfigMap (entrypoint migrations on backend pods), helm-job in the migration ConfigMap (migration Job runs)

Why

Upgrade events cannot tell a Helm install from any other install today. The server already reads these variables. With this change, helm installs and migration-Job runs become distinguishable in the telemetry.

Behaviour guard

Each default renders only when the operator does not set the same key in .Values.configMap. A user-supplied value always wins and no duplicate keys render. Deployments that set an explicit install type keep it.

Verification

  • Default render with the migration Job enabled shows all three variables with the correct per-ConfigMap values.
  • Render with configMap.LIGHTDASH_INSTALL_TYPE and configMap.LIGHTDASH_MIGRATION_EXECUTION_MODE overridden shows exactly one key per ConfigMap with the override value.
  • helm lint passes.

Chart version: 2.16.0.

Linear: SPK-1089

@linear-code

linear-code Bot commented Aug 18, 2026

Copy link
Copy Markdown

SPK-1089

@charliedowler
charliedowler marked this pull request as ready for review August 18, 2026 09:05
@charliedowler
charliedowler merged commit 8a83abf into main Aug 18, 2026
2 checks passed
@charliedowler
charliedowler deleted the feature/spk-1089 branch August 18, 2026 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant