feat: report helm install type and chart version in telemetry env - #156
Merged
Merged
Conversation
charliedowler
force-pushed
the
feature/spk-1089
branch
from
August 18, 2026 08:37
963f994 to
22c6d78
Compare
charliedowler
force-pushed
the
feature/spk-1089
branch
from
August 18, 2026 08:58
c338c4e to
82523c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The chart now identifies itself to upgrade telemetry. Three guarded defaults land in the ConfigMaps:
LIGHTDASH_INSTALL_TYPE: helm(both ConfigMaps)LIGHTDASH_HELM_CHART_VERSION: <chart version>(both ConfigMaps)LIGHTDASH_MIGRATION_EXECUTION_MODE:helm-bootin the main ConfigMap (entrypoint migrations on backend pods),helm-jobin the migration ConfigMap (migration Job runs)Why
Upgrade events cannot tell a Helm install from any other install today. The server already reads these variables. With this change, helm installs and migration-Job runs become distinguishable in the telemetry.
Behaviour guard
Each default renders only when the operator does not set the same key in
.Values.configMap. A user-supplied value always wins and no duplicate keys render. Deployments that set an explicit install type keep it.Verification
configMap.LIGHTDASH_INSTALL_TYPEandconfigMap.LIGHTDASH_MIGRATION_EXECUTION_MODEoverridden shows exactly one key per ConfigMap with the override value.helm lintpasses.Chart version: 2.16.0.
Linear: SPK-1089