Skip to content

fix: add support for v1 backConfig maxTtl, negativeCaching and serveWhileStale - #101

Merged
almeidabbm merged 2 commits into
mainfrom
12-16-fix_add_support_for_v1_backconfig_maxttl_negativecaching_and_servewhilestale
Dec 16, 2025
Merged

almeidabbm merged 2 commits into
mainfrom
12-16-fix_add_support_for_v1_backconfig_maxttl_negativecaching_and_servewhilestale

Conversation

@almeidabbm

@almeidabbm almeidabbm commented Dec 16, 2025 •

Copy link
Copy Markdown
Contributor

Towards: https://linear.app/lightdash/issue/CENG-266

Updated the BackendConfig API version from v1beta1 to v1 and bumped chart version.

What changed?

  • Changed the BackendConfig API version from cloud.google.com/v1beta1 to cloud.google.com/v1
  • Incremented the Helm chart version from 2.0.0 to 2.0.1

Why make this change?

This allows us to use maxTtl, negativeCaching, serveWhileStale in backend config.

Tested with

apiVersion: cloud.google.com/v1beta1
kind: BackendConfig
metadata:
  name: test-cdn-beta
  namespace: <namespace>
spec:
  cdn:
    enabled: true
    maxTtl: 2592000
    negativeCaching: false
    serveWhileStale: 0

and

kubectl apply -f /tmp/test-backendconfig-beta.yaml --dry-run=server -o yaml

Note: dry-run will only validate and return back the result, not apply any changes

Results of test

With v1beta
Error from server (BadRequest): error when creating "/tmp/test-backendconfig-beta.yaml": BackendConfig in version "v1beta1" cannot be handled as a BackendConfig: strict decoding error: unknown field "spec.cdn.maxTtl", unknown field "spec.cdn.negativeCaching", unknown field "spec.cdn.serveWhileStale"

With v1

apiVersion: cloud.google.com/v1
kind: BackendConfig
metadata:
# ...
spec:
  cdn:
    enabled: true
    maxTtl: 2592000
    negativeCaching: false
    serveWhileStale: 0

@almeidabbm
almeidabbm requested a review from owlas December 16, 2025 10:57

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@almeidabbm almeidabbm self-assigned this Dec 16, 2025
@almeidabbm
almeidabbm marked this pull request as ready for review December 16, 2025 11:01
@almeidabbm
almeidabbm merged commit 0724b24 into main Dec 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants