fix: add support for v1 backConfig maxTtl, negativeCaching and serveWhileStale - #101
Merged
almeidabbm merged 2 commits intoDec 16, 2025
Conversation
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
almeidabbm
marked this pull request as ready for review
December 16, 2025 11:01
owlas
approved these changes
Dec 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Towards: https://linear.app/lightdash/issue/CENG-266
Updated the BackendConfig API version from v1beta1 to v1 and bumped chart version.
What changed?
cloud.google.com/v1beta1tocloud.google.com/v1Why make this change?
This allows us to use
maxTtl, negativeCaching, serveWhileStalein backend config.Tested with
and
Note: dry-run will only validate and return back the result, not apply any changes
Results of test
With v1beta
Error from server (BadRequest): error when creating "/tmp/test-backendconfig-beta.yaml": BackendConfig in version "v1beta1" cannot be handled as a BackendConfig: strict decoding error: unknown field "spec.cdn.maxTtl", unknown field "spec.cdn.negativeCaching", unknown field "spec.cdn.serveWhileStale"With v1