Skip to content

fix: restore version fields to 1.28.0 on develop - #1286

Closed
luluiz wants to merge 1 commit into
developfrom
fix/develop-version-1.28.0
Closed

fix: restore version fields to 1.28.0 on develop#1286
luluiz wants to merge 1 commit into
developfrom
fix/develop-version-1.28.0

Conversation

@luluiz

@luluiz luluiz commented Aug 5, 2026

Copy link
Copy Markdown
Member

Summary

Why this is needed

PR #1253 advanced the ancestry between main and develop with a zero-file-change merge, so develop never actually received main's v1.28.0 version bump. As a result, develop (and branches cut from it, such as PR #1285's hotfix/v1.28.1 branch) inherited 1.27.1 in:

  • package.json
  • packages/suite/package.json
  • sonar-project.properties

That stale state can cause release automation to compute the wrong next version and makes merges from hotfix branches appear to regress main's version. Restoring 1.28.0 on develop keeps it aligned with main's actual released version (tag v1.28.0) and prevents future release/hotfix branches from inheriting the wrong base version.

Context

Summary by CodeRabbit

  • Chores
    • Updated the application and package version to 1.28.0.
    • Updated the code quality tracking version to match the new release.

The main->develop ancestry-reconciliation merge (-s ours, PR #1253) advanced
the merge-base but used a zero-file-change merge, so develop's version
fields were never updated to match main's actual v1.28.0 release. This
left package.json, packages/suite/package.json, and sonar-project.properties
at the stale 1.27.1 value, causing any branch cut from develop (e.g.
hotfix/v1.28.1) to incorrectly regress main's version when merged. This
brings develop's version fields in line with main (v1.28.0) so future
release/hotfix branches inherit the correct base version.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Aug 5, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 1aa0ef09-2bd8-47e0-8804-3f5368c57703

📥 Commits

Reviewing files that changed from the base of the PR and between 5e362cd and bf7332c.

📒 Files selected for processing (3)
  • package.json
  • packages/suite/package.json
  • sonar-project.properties

Walkthrough

The release version changed from 1.27.1 to 1.28.0 in the root package, suite package, and Sonar project metadata.

Changes

Release version alignment

Layer / File(s) Summary
Version metadata updates
package.json, packages/suite/package.json, sonar-project.properties
The root package, suite package, and Sonar project versions now use 1.28.0.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: lichtblick-bot

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description explains the change and rationale, but it omits the required User-Facing Changes, Description, and Checklist sections. Add the required template sections and complete the checklist, including testing and unit-test status.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly identifies the restoration of version fields to 1.28.0 on develop.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/develop-version-1.28.0

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2026

Copy link
Copy Markdown

@luluiz
luluiz enabled auto-merge August 5, 2026 17:30
@luluiz

luluiz commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

Superseded by a new PR from bugfix/develop-version-1.28.0 — branch naming rule requires 'feature/', 'bugfix/', or 'dependabot/' prefix when targeting develop. Closing this one in favor of the renamed branch.

@luluiz luluiz closed this Aug 5, 2026
auto-merge was automatically disabled August 5, 2026 18:02

Pull request was closed

@luluiz
luluiz deleted the fix/develop-version-1.28.0 branch August 5, 2026 18:02
luluiz added a commit that referenced this pull request Aug 6, 2026
## Summary
Restore develop's stale version fields to `1.28.0` in:
- `package.json`
- `packages/suite/package.json`
- `sonar-project.properties`

## Root cause
The main -> develop ancestry-reconciliation merge done with `-s ours` in
PR #1253 advanced the merge-base without bringing over the version-file
changes from main. As a result, develop's release version fields stayed
at `1.27.1` even though main had already released `v1.28.0`.

That stale state then caused hotfix/v1.28.1 (branched from develop) to
regress main's version metadata in PR #1285.

## Why this PR
This PR brings develop's version fields back in line with main
(`v1.28.0`) so future release and hotfix branches inherit the correct
base version.

## References
- PR #1253
- PR #1285
- Supersedes and replaces closed PR #1286 (renamed branch to satisfy
develop branch naming rules)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant