Skip to content

gcc14 fixes - #536

Closed
ToKe79 wants to merge 1 commit into
libretro:developfrom
ToKe79:gcc14_fixes
Closed

gcc14 fixes#536
ToKe79 wants to merge 1 commit into
libretro:developfrom
ToKe79:gcc14_fixes

Conversation

@ToKe79

@ToKe79 ToKe79 commented May 23, 2024

Copy link
Copy Markdown

No description provided.

Comment thread libretro/libretro.c

retro_thread = co_active();
game_thread = co_create(65536 * sizeof(void*) * 16, EmuThreadFunction);
game_thread = co_create(65536 * sizeof(void*) * 16, (void(*)(void))EmuThreadFunction);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 26dfd67 is a bit better than this workaround.

@m4xw

m4xw commented Jul 15, 2024

Copy link
Copy Markdown
Collaborator

Shouldnt use GL_USE_DLSYM unless its a broken frontend, EmuThreadFunction changes i have wip from my emscripten stuff
Some of the stdexcept changes are redundant

@gouchi gouchi mentioned this pull request Aug 13, 2024
@Shoegzer

Copy link
Copy Markdown

Builds fine with this PR. I can close #546 once this is merged.

@pstef

pstef commented Aug 14, 2024

Copy link
Copy Markdown
Contributor

Builds fine with this PR. I can close #546 once this is merged.

Why this over #526?

@Shoegzer

Copy link
Copy Markdown

Sorry, I didn't even realize that was there.

@ToKe79

ToKe79 commented Jan 29, 2025

Copy link
Copy Markdown
Author

This PR can be closed, no issues with gcc14 anymore, except for this:

https://github.com/libretro/mupen64plus-libretro-nx/pull/536/files#diff-f4fdf68db2fd04f2484065df2aa0112d17b6c6f9b72ed55d87baf7cafecc745eR22

fails due to impilict declarations of read, write, lseek, ...

@ToKe79 ToKe79 closed this Jan 29, 2025
@pstef

pstef commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

fails due to impilict declarations of read, write, lseek, ...

Potentially fixed with
3c3e7fb

Discussion #526 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants