Skip to content

Increase wallet test coverage. #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
evoskuil merged 5 commits into from
Sep 11, 2026
Merged

Increase wallet test coverage. #1975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e3827d0
Correct inverted output value deserialization test.
evoskuil Sep 11, 2026
65089e0
Add psbt transaction tests to full coverage.
evoskuil Sep 11, 2026
56c459d
Remove legacy stealth addresses and cover stealth math.
evoskuil Sep 11, 2026
136e7c5
Add ec_public tests to full coverage.
evoskuil Sep 11, 2026
b4ceb29
Add ec_private tests to full reachable coverage.
evoskuil Sep 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion builds/cmake/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ project( libbitcoin-system
LANGUAGES C CXX )


set( repository_root_dir "${CMAKE_CURRENT_SOURCE_DIR}/../../" )
set( repository_root_dir "${CMAKE_CURRENT_SOURCE_DIR}/../.." )

if ( MSVC )
set( CMAKE_STATIC_LIBRARY_PREFIX "lib" )
Expand Down
9 changes: 0 additions & 9 deletions builds/gnu/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,9 +203,6 @@ src_libbitcoin_system_la_SOURCES = \
${srcdir}/../../src/wallet/addresses/bitcoin_uri.cpp \
${srcdir}/../../src/wallet/addresses/payment_address.cpp \
${srcdir}/../../src/wallet/addresses/qr_code.cpp \
${srcdir}/../../src/wallet/addresses/stealth_address.cpp \
${srcdir}/../../src/wallet/addresses/stealth_receiver.cpp \
${srcdir}/../../src/wallet/addresses/stealth_sender.cpp \
${srcdir}/../../src/wallet/addresses/tiff.cpp \
${srcdir}/../../src/wallet/addresses/uri.cpp \
${srcdir}/../../src/wallet/addresses/witness_address.cpp \
Expand Down Expand Up @@ -896,9 +893,6 @@ include_bitcoin_system_wallet_addresses_HEADERS = \
${srcdir}/../../include/bitcoin/system/wallet/addresses/checked.hpp \
${srcdir}/../../include/bitcoin/system/wallet/addresses/payment_address.hpp \
${srcdir}/../../include/bitcoin/system/wallet/addresses/qr_code.hpp \
${srcdir}/../../include/bitcoin/system/wallet/addresses/stealth_address.hpp \
${srcdir}/../../include/bitcoin/system/wallet/addresses/stealth_receiver.hpp \
${srcdir}/../../include/bitcoin/system/wallet/addresses/stealth_sender.hpp \
${srcdir}/../../include/bitcoin/system/wallet/addresses/tiff.hpp \
${srcdir}/../../include/bitcoin/system/wallet/addresses/uri.hpp \
${srcdir}/../../include/bitcoin/system/wallet/addresses/uri_reader.hpp \
Expand Down Expand Up @@ -1212,9 +1206,6 @@ test_libbitcoin_system_test_SOURCES = \
${srcdir}/../../test/wallet/addresses/checked.cpp \
${srcdir}/../../test/wallet/addresses/payment_address.cpp \
${srcdir}/../../test/wallet/addresses/qr_code.cpp \
${srcdir}/../../test/wallet/addresses/stealth_address.cpp \
${srcdir}/../../test/wallet/addresses/stealth_receiver.cpp \
${srcdir}/../../test/wallet/addresses/stealth_sender.cpp \
${srcdir}/../../test/wallet/addresses/tiff.cpp \
${srcdir}/../../test/wallet/addresses/uri.cpp \
${srcdir}/../../test/wallet/addresses/uri_reader.cpp \
Expand Down
2 changes: 1 addition & 1 deletion builds/gnu/configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ AC_ARG_VAR([CC], "C compiler to use, such as gcc or clang")
AC_ARG_VAR([CXX], "C++ compiler to use, such as g++ or clang++")
AC_ARG_VAR([PKG_CONFIG_PATH], "Additional directories for package discovery.")

repository_root_dir="@abs_top_srcdir@/../.."
repository_root_dir=`cd "${srcdir}/../.." && pwd`

# Check for baseline language coverage in the compiler for the C++20 standard.
#------------------------------------------------------------------------------
Expand Down
3 changes: 0 additions & 3 deletions builds/msvc/vs2022/libbitcoin-system-test/libbitcoin-system-test.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,9 +417,6 @@
<ClCompile Include="..\..\..\..\test\wallet\addresses\checked.cpp" />
<ClCompile Include="..\..\..\..\test\wallet\addresses\payment_address.cpp" />
<ClCompile Include="..\..\..\..\test\wallet\addresses\qr_code.cpp" />
<ClCompile Include="..\..\..\..\test\wallet\addresses\stealth_address.cpp" />
<ClCompile Include="..\..\..\..\test\wallet\addresses\stealth_receiver.cpp" />
<ClCompile Include="..\..\..\..\test\wallet\addresses\stealth_sender.cpp" />
<ClCompile Include="..\..\..\..\test\wallet\addresses\tiff.cpp" />
<ClCompile Include="..\..\..\..\test\wallet\addresses\uri.cpp" />
<ClCompile Include="..\..\..\..\test\wallet\addresses\uri_reader.cpp" />
Expand Down
9 changes: 0 additions & 9 deletions builds/msvc/vs2022/libbitcoin-system-test/libbitcoin-system-test.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,15 +798,6 @@
<ClCompile Include="..\..\..\..\test\wallet\addresses\qr_code.cpp">
<Filter>src\wallet\addresses</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\wallet\addresses\stealth_address.cpp">
<Filter>src\wallet\addresses</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\wallet\addresses\stealth_receiver.cpp">
<Filter>src\wallet\addresses</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\wallet\addresses\stealth_sender.cpp">
<Filter>src\wallet\addresses</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\wallet\addresses\tiff.cpp">
<Filter>src\wallet\addresses</Filter>
</ClCompile>
Expand Down
6 changes: 0 additions & 6 deletions builds/msvc/vs2022/libbitcoin-system/libbitcoin-system.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,9 +317,6 @@
<ClCompile Include="..\..\..\..\src\wallet\addresses\qrencode\qrspec.c" />
<ClCompile Include="..\..\..\..\src\wallet\addresses\qrencode\rsecc.c" />
<ClCompile Include="..\..\..\..\src\wallet\addresses\qrencode\split.c" />
<ClCompile Include="..\..\..\..\src\wallet\addresses\stealth_address.cpp" />
<ClCompile Include="..\..\..\..\src\wallet\addresses\stealth_receiver.cpp" />
<ClCompile Include="..\..\..\..\src\wallet\addresses\stealth_sender.cpp" />
<ClCompile Include="..\..\..\..\src\wallet\addresses\tiff.cpp" />
<ClCompile Include="..\..\..\..\src\wallet\addresses\uri.cpp" />
<ClCompile Include="..\..\..\..\src\wallet\addresses\witness_address.cpp" />
Expand Down Expand Up @@ -655,9 +652,6 @@
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\checked.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\payment_address.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\qr_code.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\stealth_address.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\stealth_receiver.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\stealth_sender.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\tiff.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\uri.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\uri_reader.hpp" />
Expand Down
18 changes: 0 additions & 18 deletions builds/msvc/vs2022/libbitcoin-system/libbitcoin-system.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,15 +675,6 @@
<ClCompile Include="..\..\..\..\src\wallet\addresses\qrencode\split.c">
<Filter>src\wallet\addresses\qrencode</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\src\wallet\addresses\stealth_address.cpp">
<Filter>src\wallet\addresses</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\src\wallet\addresses\stealth_receiver.cpp">
<Filter>src\wallet\addresses</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\src\wallet\addresses\stealth_sender.cpp">
<Filter>src\wallet\addresses</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\src\wallet\addresses\tiff.cpp">
<Filter>src\wallet\addresses</Filter>
</ClCompile>
Expand Down Expand Up @@ -1625,15 +1616,6 @@
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\qr_code.hpp">
<Filter>include\bitcoin\system\wallet\addresses</Filter>
</ClInclude>
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\stealth_address.hpp">
<Filter>include\bitcoin\system\wallet\addresses</Filter>
</ClInclude>
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\stealth_receiver.hpp">
<Filter>include\bitcoin\system\wallet\addresses</Filter>
</ClInclude>
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\stealth_sender.hpp">
<Filter>include\bitcoin\system\wallet\addresses</Filter>
</ClInclude>
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\tiff.hpp">
<Filter>include\bitcoin\system\wallet\addresses</Filter>
</ClInclude>
Expand Down
3 changes: 0 additions & 3 deletions builds/msvc/vs2026/libbitcoin-system-test/libbitcoin-system-test.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,9 +417,6 @@
<ClCompile Include="..\..\..\..\test\wallet\addresses\checked.cpp" />
<ClCompile Include="..\..\..\..\test\wallet\addresses\payment_address.cpp" />
<ClCompile Include="..\..\..\..\test\wallet\addresses\qr_code.cpp" />
<ClCompile Include="..\..\..\..\test\wallet\addresses\stealth_address.cpp" />
<ClCompile Include="..\..\..\..\test\wallet\addresses\stealth_receiver.cpp" />
<ClCompile Include="..\..\..\..\test\wallet\addresses\stealth_sender.cpp" />
<ClCompile Include="..\..\..\..\test\wallet\addresses\tiff.cpp" />
<ClCompile Include="..\..\..\..\test\wallet\addresses\uri.cpp" />
<ClCompile Include="..\..\..\..\test\wallet\addresses\uri_reader.cpp" />
Expand Down
9 changes: 0 additions & 9 deletions builds/msvc/vs2026/libbitcoin-system-test/libbitcoin-system-test.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -798,15 +798,6 @@
<ClCompile Include="..\..\..\..\test\wallet\addresses\qr_code.cpp">
<Filter>src\wallet\addresses</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\wallet\addresses\stealth_address.cpp">
<Filter>src\wallet\addresses</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\wallet\addresses\stealth_receiver.cpp">
<Filter>src\wallet\addresses</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\wallet\addresses\stealth_sender.cpp">
<Filter>src\wallet\addresses</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\test\wallet\addresses\tiff.cpp">
<Filter>src\wallet\addresses</Filter>
</ClCompile>
Expand Down
6 changes: 0 additions & 6 deletions builds/msvc/vs2026/libbitcoin-system/libbitcoin-system.vcxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,9 +317,6 @@
<ClCompile Include="..\..\..\..\src\wallet\addresses\qrencode\qrspec.c" />
<ClCompile Include="..\..\..\..\src\wallet\addresses\qrencode\rsecc.c" />
<ClCompile Include="..\..\..\..\src\wallet\addresses\qrencode\split.c" />
<ClCompile Include="..\..\..\..\src\wallet\addresses\stealth_address.cpp" />
<ClCompile Include="..\..\..\..\src\wallet\addresses\stealth_receiver.cpp" />
<ClCompile Include="..\..\..\..\src\wallet\addresses\stealth_sender.cpp" />
<ClCompile Include="..\..\..\..\src\wallet\addresses\tiff.cpp" />
<ClCompile Include="..\..\..\..\src\wallet\addresses\uri.cpp" />
<ClCompile Include="..\..\..\..\src\wallet\addresses\witness_address.cpp" />
Expand Down Expand Up @@ -655,9 +652,6 @@
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\checked.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\payment_address.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\qr_code.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\stealth_address.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\stealth_receiver.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\stealth_sender.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\tiff.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\uri.hpp" />
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\uri_reader.hpp" />
Expand Down
18 changes: 0 additions & 18 deletions builds/msvc/vs2026/libbitcoin-system/libbitcoin-system.vcxproj.filters
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,15 +675,6 @@
<ClCompile Include="..\..\..\..\src\wallet\addresses\qrencode\split.c">
<Filter>src\wallet\addresses\qrencode</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\src\wallet\addresses\stealth_address.cpp">
<Filter>src\wallet\addresses</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\src\wallet\addresses\stealth_receiver.cpp">
<Filter>src\wallet\addresses</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\src\wallet\addresses\stealth_sender.cpp">
<Filter>src\wallet\addresses</Filter>
</ClCompile>
<ClCompile Include="..\..\..\..\src\wallet\addresses\tiff.cpp">
<Filter>src\wallet\addresses</Filter>
</ClCompile>
Expand Down Expand Up @@ -1625,15 +1616,6 @@
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\qr_code.hpp">
<Filter>include\bitcoin\system\wallet\addresses</Filter>
</ClInclude>
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\stealth_address.hpp">
<Filter>include\bitcoin\system\wallet\addresses</Filter>
</ClInclude>
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\stealth_receiver.hpp">
<Filter>include\bitcoin\system\wallet\addresses</Filter>
</ClInclude>
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\stealth_sender.hpp">
<Filter>include\bitcoin\system\wallet\addresses</Filter>
</ClInclude>
<ClInclude Include="..\..\..\..\include\bitcoin\system\wallet\addresses\tiff.hpp">
<Filter>include\bitcoin\system\wallet\addresses</Filter>
</ClInclude>
Expand Down
3 changes: 0 additions & 3 deletions include/bitcoin/system.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,9 +298,6 @@
#include <bitcoin/system/wallet/addresses/checked.hpp>
#include <bitcoin/system/wallet/addresses/payment_address.hpp>
#include <bitcoin/system/wallet/addresses/qr_code.hpp>
#include <bitcoin/system/wallet/addresses/stealth_address.hpp>
#include <bitcoin/system/wallet/addresses/stealth_receiver.hpp>
#include <bitcoin/system/wallet/addresses/stealth_sender.hpp>
#include <bitcoin/system/wallet/addresses/tiff.hpp>
#include <bitcoin/system/wallet/addresses/uri.hpp>
#include <bitcoin/system/wallet/addresses/uri_reader.hpp>
Expand Down
3 changes: 0 additions & 3 deletions include/bitcoin/system/wallet/addresses/bitcoin_uri.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
#include <map>
#include <bitcoin/system/define.hpp>
#include <bitcoin/system/wallet/addresses/payment_address.hpp>
#include <bitcoin/system/wallet/addresses/stealth_address.hpp>
#include <bitcoin/system/wallet/addresses/uri_reader.hpp>

namespace libbitcoin {
Expand Down Expand Up @@ -62,7 +61,6 @@ class BC_API bitcoin_uri
std::string r() const NOEXCEPT;
std::string address() const NOEXCEPT;
payment_address payment() const NOEXCEPT;
stealth_address stealth() const NOEXCEPT;
std::string parameter(const std::string& key) const NOEXCEPT;

/// Property setters.
Expand All @@ -72,7 +70,6 @@ class BC_API bitcoin_uri
void set_r(const std::string& r) NOEXCEPT;
bool set_address(const std::string& address) NOEXCEPT;
void set_address(const payment_address& payment) NOEXCEPT;
void set_address(const stealth_address& stealth) NOEXCEPT;

/// uri_reader implementation.
bool set_scheme(const std::string& scheme) NOEXCEPT;
Expand Down
114 changes: 0 additions & 114 deletions include/bitcoin/system/wallet/addresses/stealth_address.hpp
View file
Open in desktop

This file was deleted.

Loading
Loading