Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Each Key_Shared dispatch batch creates two consumer-keyed maps: one groups entries selected for each consumer and the other tracks the consumer's remaining permits. These short-lived
HashMaps allocate a node for every participating consumer and spend measurable CPU inHashMap.putValwhile the dispatcher monitor is held.Modifications
Use FastUtil
Object2ObjectOpenHashMapfor the two batch-local maps and size them from the connected consumer count. The maps keep the sameConsumer.equalsandhashCodesemantics, values, and lifetime. Routing, permit accounting, ordering, and monitor scope are unchanged.Add a focused JMH benchmark that constructs both maps and groups 1,000 entries across ten consumers.
Verifying this change
The focused benchmark measured:
HashMapA fanout screen used 500 producer connections, one topic, twenty Key_Shared subscriptions, and ten consumers per subscription. Two changed runs and three unchanged runs delivered every one of the expected twenty million fanout copies with zero duplicate, out-of-order, or invalid messages. Mean producer rates were 32,101 and 31,980 msg/s respectively, a flat 0.38% difference within run variation. The end-to-end runs are correctness and material-regression evidence; no whole-workload throughput gain is claimed.
Validation:
PersistentStickyKeyDispatcherMultipleConsumersTest./gradlew quickCheck