Repository navigation
Gate compile options by Less version - #32
Merged
Merged
Conversation
Render the Options panel from a per-version descriptor list and send only the options valid for the active version, under that version's name: - < 3.7.0: strictMath switch; >= 3.7.0: math select (less.js 76c10345, v3.7.0) - < 5.0.0: strictUnits switch, deprecated compress switch; >= 5.0.0: unitMode select, collapseNesting switch (5.0.0-alpha options.js) The store keeps every key (URL hash unchanged); renderOptions() filters.
|
Warning Review limit reachedNext included review available in 38 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Options panel is now rendered from
src/options.ts(supportedOptions(version)), andupdateVue()sends onlyrenderOptions(store, version)toless.render— nothing invalid or misnamed for the active version.strictMath< 3.7.0mathin less.js76c10345(first tagv3.7.0)mathalways/parens-division/parens>= 3.7.0strictUnits< 5.0.0unitMode(packages/less/lib/options.jsonalpha,7ed6ec4e)unitModeloose/strict/preserve>= 5.0.0collapseNesting>= 5.0.07d07c112compress< 5.0.0unsupportedAlphaOptionsPrereleases compare by numeric core (
5.0.0-alpha.2→5.0.0). Controls show/hide reactively on version change; the existingstorewatch re-renders. The store still holds every key, so the URL hash format is unchanged.Verified
pnpm buildgreen. In the dev server, wrappingless.renderto log the options object:4.9.1→ Math mode, Strict units, Minify; sends{ math, strictUnits, compress }3.6.0→ Strict math switch instead of Math; sends{ strictMath, strictUnits, compress }; compiles5.0.0-alpha.2 (experimental)→ Math mode, Unit mode, Collapse nesting; sends{ math, unitMode, collapseNesting }(control visibility + option object only — that alpha's bundle 404s, so no live 5.x compile)4.9.1→{ math, strictUnits, compress }, nocollapseNesting/unitMode