Add Atlas Cloud provider - #194
binyangzhu000-sudo wants to merge 6 commits into
Conversation
saschabuehrle
left a comment
There was a problem hiding this comment.
Thanks for the compact OpenAI-compatible provider implementation. The endpoint matches Atlas Cloud’s current official docs and the isolated tests, Ruff, and Black pass, but two runtime integration blockers remain.
Required before merge:
- Register
atlascloudinModelConfig.validate_providerandPROVIDER_CAPABILITIES. TodayModelConfig(name="x", provider="atlascloud", cost=0)raises a validation error, so aCascadeAgentcannot configure it. - Fix provider attribution inherited from
OpenAIProvider. A mocked successful request correctly callshttps://api.atlascloud.ai/v1/chat/completionsbut returnsModelResponse.provider == "openai"; inherited errors also identify OpenAI. This breaks provider telemetry and routing traces. - Fix or explicitly define cost behavior. Current
_get_litellm_prefix()producesopenai/qwen/qwen3.5-flash, which LiteLLM rejects before falling back to inherited OpenAI estimates. Add Atlas-aware estimation/capability semantics and tests. - Add an end-to-end provider test covering ModelConfig/registry resolution plus response attribution, not only constructor registration.
Please update against current main and re-request review.
|
Updated against current Worth flagging first: all four required items were addressed in
Validation
One note on Black, stated plainly rather than silently changed: |
|
@saschabuehrle Updated against current I should be straightforward about the state of your four blockers: they were addressed in
New in this update:
Verification on the merged branch:
The 8 failures are all |
Summary
atlascloudin the provider registry and LiteLLM prefix mappingValidation
python3 -m pytest -o addopts='' tests/test_atlascloud.py tests/test_agent_module_callable.py -qpython3 -m compileall cascadeflow/providers/atlascloud.py cascadeflow/providers/__init__.py cascadeflow/providers/base.py tests/test_atlascloud.pygit diff --checkqwen/qwen3.5-flashanddeepseek-ai/deepseek-v4-proNotes: local environment does not have
rufforblackinstalled, so those checks could not be run here.README: no README changes; docs update only, no sponsor/logo/credits/partner promotion.