feat: don't reduce proofs in is_def_eq_core - #15103
Draft
arthur-adjedj wants to merge 3 commits into
Draft
arthur-adjedj wants to merge 3 commits into
arthur-adjedj wants to merge 3 commits into
Conversation
5 tasks
|
Mathlib CI status (docs):
|
Contributor
Author
|
!bench |
Contributor
Author
|
!bench mathlib |
|
Benchmark results for 4f29e98 against fe53f21 are in. There are significant results. @arthur-adjedj
Medium changes (2🟥)
Small changes (1✅, 32🟥)
|
|
Benchmark results for leanprover-community/mathlib4-nightly-testing@d7ce512 against leanprover-community/mathlib4-nightly-testing@2025d0b are in. No significant results found. @arthur-adjedj
Small changes (1✅, 1🟥)
|
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/batteries
that referenced
this pull request
Sep 10, 2026
mathlib-nightly-testing Bot
pushed a commit
to leanprover-community/mathlib4-nightly-testing
that referenced
this pull request
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ensures
is_def_eq_proof_irrelruns before reducing any potential proofs inis_def_eq_corerather than after. This is already the order in which things run in the elaborator, so no need for any changes there.Related to #14977